refactor(Schema): Remove optimistic string format inference from SchemaGenerator

Author: CodeWithKyrian

src/Support/SchemaGenerator.php

@@ -131,20 +131,10 @@ public function fromMethodParameters(ReflectionMethod $method): array
                     }
                 }
 
-                // Add format for specific string types (basic inference)
-                if (isset($paramSchema['type'])) {
-                    $schemaType = is_array($paramSchema['type']) ? (in_array('string', $paramSchema['type']) ? 'string' : null) : $paramSchema['type'];
-                    if ($schemaType === 'string') {
-                        if (stripos($name, 'email') !== false || stripos($typeString, 'email') !== false) {
-                            $paramSchema['format'] = 'email';
-                        } elseif (stripos($name, 'date') !== false || stripos($typeString, 'date') !== false) {
-                            $paramSchema['format'] = 'date-time'; // Or 'date' depending on convention
-                        } elseif (stripos($name, 'uri') !== false || stripos($name, 'url') !== false || stripos($typeString, 'uri') !== false || stripos($typeString, 'url') !== false) {
-                            $paramSchema['format'] = 'uri';
-                        }
-                        // Add more format detections if needed
-                    }
-                }
+                // TODO: Revisit format inference or add explicit @schema docblock tag for formats in a future version.
+                // For now, parameters typed as 'string' will not have a 'format' keyword automatically added.
+                // Users needing specific string format validation (date-time, email, uri, regex pattern)
+                // would need to perform that validation within their tool/resource handler method.
 
                 // Handle array items type if possible
                 if (isset($paramSchema['type'])) {
@@ -176,7 +166,7 @@ public function fromMethodParameters(ReflectionMethod $method): array
 
         if (empty($schema['properties'])) {
             // Keep properties object even if empty, per spec
-            $schema['properties'] = new stdClass();
+            $schema['properties'] = new stdClass;
         }
         if (empty($schema['required'])) {
             unset($schema['required']);

tests/Unit/Support/SchemaGeneratorTest.php

@@ -56,7 +56,7 @@ function setupDocBlockExpectations(Mockery\MockInterface $parserMock, Reflection
 
     $schema = $this->schemaGenerator->fromMethodParameters($method);
 
-    expect($schema)->toEqual(['type' => 'object', 'properties' => new \stdClass()]);
+    expect($schema)->toEqual(['type' => 'object', 'properties' => new \stdClass]);
     expect($schema)->not->toHaveKey('required');
 });
 
@@ -216,15 +216,3 @@ function setupDocBlockExpectations(Mockery\MockInterface $parserMock, Reflection
     expect($schema['properties']['p1'])->toEqual(['type' => 'string', 'description' => 'Docblock overrides int']);
     expect($schema['required'])->toEqualCanonicalizing(['p1']);
 });
-
-test('generates schema infers format from parameter name', function () {
-    $method = new ReflectionMethod(SchemaGeneratorTestStub::class, 'formatParams');
-    setupDocBlockExpectations($this->docBlockParserMock, $method);
-
-    $schema = $this->schemaGenerator->fromMethodParameters($method);
-
-    expect($schema['properties']['email'])->toEqual(['type' => 'string', 'description' => 'Email address', 'format' => 'email']);
-    expect($schema['properties']['url'])->toEqual(['type' => 'string', 'description' => 'URL string', 'format' => 'uri']);
-    expect($schema['properties']['dateTime'])->toEqual(['type' => 'string', 'description' => 'ISO Date time string', 'format' => 'date-time']);
-    expect($schema['required'])->toEqualCanonicalizing(['email', 'url', 'dateTime']);
-});