Merge pull request moneyphp#30 from camspiers/currency-pair-exception

Added better exception for failure to parse currency pair ISO string

Author: mathiasverraes

lib/Money/CurrencyPair.php

@@ -52,8 +52,12 @@ public static function createFromIso($iso)
 
         $matches = array();
         if (!preg_match($pattern, $iso, $matches)) {
-            // @todo better exception
-            throw new \Exception();
+            throw new InvalidArgumentException(
+                sprintf(
+                    "Can't create currency pair from ISO string '%s', format of string is invalid",
+                    $iso
+                )
+            );
         }
 
         return new static(new Currency($matches[1]), new Currency($matches[2]), $matches[3]);

tests/Money/Tests/CurrencyPairTest.php

@@ -38,4 +38,14 @@ public function ParsesIso()
         $expected = new CurrencyPair(new Currency('EUR'), new Currency('USD'), 1.2500);
         $this->assertEquals($expected, $pair);
     }
+
+    /**
+     * @test
+     * @expectedException \Money\InvalidArgumentException
+     * @expectedExceptionMessage Can't create currency pair from ISO string '1.2500', format of string is invalid
+     */
+    public function ParsesIsoWithException()
+    {
+        CurrencyPair::createFromIso('1.2500');
+    }
 }