Skip to content

Commit 0a2c84d

Browse files
committed
Fixed code review
1 parent 062679e commit 0a2c84d

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/Identity/v3/Models/Token.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,19 +121,16 @@ public function create(array $data): Creatable
121121
$response = $this->execute($this->api->postTokens(), $data);
122122
$token = $this->populateFromResponse($response);
123123

124-
125-
/**
126-
* Cache response as an array to export if needed.
127-
* Added key `id` which is auth token from HTTP header X-Subject-Token
128-
*/
124+
// Cache response as an array to export if needed.
125+
// Added key `id` which is auth token from HTTP header X-Subject-Token
129126
$this->cachedToken = Utils::flattenJson(Utils::jsonDecode($response), $this->resourceKey);
130127
$this->cachedToken['id'] = $token->id;
131128

132129
return $token;
133130
}
134131

135132
/**
136-
* Retrieves an array serializable representation of authentication token.
133+
* Returns a serialized representation of an authentication token.
137134
*
138135
* Initialize OpenStack object using $params['cachedToken'] to reduce HTTP authentication call.
139136
*

src/Identity/v3/Service.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ public function authenticate(array $options): array
6060
* @param array $cachedToken {@see \OpenStack\Identity\v3\Models\Token::export}
6161
*
6262
* @return Models\Token
63-
*
6463
*/
6564
public function generateTokenFromCache(array $cachedToken): Models\Token
6665
{

0 commit comments

Comments
 (0)