add more tests

Author: Jamie Hannaford

src/Common/Error/Builder.php

@@ -86,8 +86,6 @@ private function str(MessageInterface $message)
             $msg = 'HTTP/' . $message->getProtocolVersion() . ' '
                 . $message->getStatusCode() . ' '
                 . $message->getReasonPhrase();
-        } else {
-            throw new \InvalidArgumentException('Unknown message type');
         }
 
         foreach ($message->getHeaders() as $name => $values) {

src/ObjectStore/v1/Service.php

@@ -61,10 +61,19 @@ public function createContainer(array $data)
         return $this->getContainer()->create($data);
     }
 
+    /**
+     * Checks the existence of a container.
+     *
+     * @param string $name The name of the container
+     *
+     * @return bool             TRUE if exists, FALSE if it doesn't
+     * @throws BadResponseError Thrown for any non 404 status error
+     */
     public function containerExists($name)
     {
         try {
-            $this->getContainer($name);
+            $this->execute($this->api->headContainer(), ['name' => $name]);
+            return true;
         } catch (BadResponseError $e) {
             if ($e->getResponse()->getStatusCode() === 404) {
                 return false;

tests/unit/Common/Error/BuilderTest.php

@@ -12,6 +12,8 @@
 use OpenStack\Common\Error\BadResponseError;
 use OpenStack\Common\Error\Builder;
 use OpenStack\Common\Error\UserInputError;
+use Psr\Http\Message\MessageInterface;
+use Psr\Http\Message\StreamInterface;
 
 class BuilderTest extends \PHPUnit_Framework_TestCase
 {
@@ -118,4 +120,4 @@ public function test_dead_links_are_ignored()
 
         $this->assertEquals($e, $this->builder->userInputError($expected, $value, 'sdffsda'));
     }
-}
+}

tests/unit/ObjectStore/v1/Models/ContainerTest.php

@@ -190,6 +190,18 @@ public function test_it_chunks_according_to_provided_segment_size()
             'segmentContainer' => 'segments',
         ];
 
+        // check container creation
+        $e = new BadResponseError();
+        $e->setRequest(new Request('HEAD', 'segments'));
+        $e->setResponse(new Response(404));
+
+        $this->client
+            ->request('HEAD', 'segments', ['headers' => []])
+            ->shouldBeCalled()
+            ->willThrow($e);
+
+        $this->setupMock('PUT', 'segments', null, [], new Response(201));
+
         $this->setupMock('PUT', 'segments/objectPrefix/1', $stream->read(10), [], new Response(201));
         $this->setupMock('PUT', 'segments/objectPrefix/2', $stream->read(10), [], new Response(201));
         $this->setupMock('PUT', 'segments/objectPrefix/3', $stream->read(10), [], new Response(201));

tests/unit/ObjectStore/v1/ServiceTest.php

@@ -2,7 +2,9 @@
 
 namespace OpenStack\Test\ObjectStore\v1;
 
+use GuzzleHttp\Psr7\Request;
 use GuzzleHttp\Psr7\Response;
+use OpenStack\Common\Error\BadResponseError;
 use OpenStack\ObjectStore\v1\Api;
 use OpenStack\ObjectStore\v1\Models\Account;
 use OpenStack\ObjectStore\v1\Models\Container;
@@ -44,4 +46,42 @@ public function test_It_Create_Containers()
         $this->setupMock('PUT', 'foo', null, [], 'Created');
         $this->service->createContainer(['name' => 'foo']);
     }
+
+    public function test_it_returns_true_for_existing_containers()
+    {
+        $this->setupMock('HEAD', 'foo', null, [], new Response(200));
+
+        $this->assertTrue($this->service->containerExists('foo'));
+    }
+
+    public function test_it_returns_false_if_container_does_not_exist()
+    {
+        $e = new BadResponseError();
+        $e->setRequest(new Request('HEAD', 'foo'));
+        $e->setResponse(new Response(404));
+
+        $this->client
+            ->request('HEAD', 'foo', ['headers' => []])
+            ->shouldBeCalled()
+            ->willThrow($e);
+
+        $this->assertFalse($this->service->containerExists('foo'));
+    }
+
+    /**
+     * @expectedException \OpenStack\Common\Error\BadResponseError
+     */
+    public function test_it_throws_exception_when_error()
+    {
+        $e = new BadResponseError();
+        $e->setRequest(new Request('HEAD', 'foo'));
+        $e->setResponse(new Response(500));
+
+        $this->client
+            ->request('HEAD', 'foo', ['headers' => []])
+            ->shouldBeCalled()
+            ->willThrow($e);
+
+        $this->assertFalse($this->service->containerExists('foo'));
+    }
 }