Merge pull request #55 from haphan/catalog-name

[rfr] Add catalog name and type for identity service

Author: Jamie Hannaford

src/OpenStack.php

@@ -118,7 +118,7 @@ public function networkingV2ExtSecGroups(array $options = []): \OpenStack\Networ
      */
     public function identityV2(array $options = []): \OpenStack\Identity\v2\Service
     {
-        $defaults = ['catalogName' => false, 'catalogType' => false];
+        $defaults = ['catalogName' => 'keystone', 'catalogType' => 'identity'];
         return $this->builder->createService('Identity\\v2', array_merge($defaults, $options));
     }
 
@@ -131,7 +131,7 @@ public function identityV2(array $options = []): \OpenStack\Identity\v2\Service
      */
     public function identityV3(array $options = []): \OpenStack\Identity\v3\Service
     {
-        $defaults = ['catalogName' => false, 'catalogType' => false];
+        $defaults = ['catalogName' => 'keystone', 'catalogType' => 'identity'];
         return $this->builder->createService('Identity\\v3', array_merge($defaults, $options));
     }
 

tests/unit/OpenStackTest.php

@@ -32,7 +32,7 @@ public function test_it_supports_compute_v2()
     public function test_it_supports_identity_v2()
     {
         $this->builder
-            ->createService('Identity\\v2', ['catalogName' => false, 'catalogType' => false])
+            ->createService('Identity\\v2', ['catalogName' => 'keystone', 'catalogType' => 'identity'])
             ->shouldBeCalled()
             ->willReturn($this->service('Identity', 2));
 
@@ -42,7 +42,7 @@ public function test_it_supports_identity_v2()
     public function test_it_supports_identity_v3()
     {
         $this->builder
-            ->createService('Identity\\v3', ['catalogName' => false, 'catalogType' => false])
+            ->createService('Identity\\v3', ['catalogName' => 'keystone', 'catalogType' => 'identity'])
             ->shouldBeCalled()
             ->willReturn($this->service('Identity', 3));