SecurityGroup tests

Author: haphan

src/Networking/v2/Extensions/SecurityGroups/Api.php

@@ -6,7 +6,7 @@
 
 class Api extends AbstractApi
 {
-    private $pathPrefix = '/v2.0/';
+    private $pathPrefix = 'v2.0';
 
     public function __construct()
     {
@@ -23,7 +23,7 @@ public function getSecurityGroups()
     {
         return [
             'method' => 'GET',
-            'path'   => $this->pathPrefix . 'security-groups',
+            'path'   => $this->pathPrefix . '/security-groups',
             'params' => [],
         ];
     }
@@ -37,7 +37,7 @@ public function postSecurityGroups()
     {
         return [
             'method'  => 'POST',
-            'path'    => $this->pathPrefix . 'security-groups',
+            'path'    => $this->pathPrefix . '/security-groups',
             'jsonKey' => 'security_group',
             'params'  => [
                 'description' => $this->params->descriptionJson(),
@@ -55,7 +55,7 @@ public function putSecurityGroups()
     {
         return [
             'method'  => 'PUT',
-            'path'    => $this->pathPrefix . 'security-groups/{id}',
+            'path'    => $this->pathPrefix . '/security-groups/{id}',
             'jsonKey' => 'security_group',
             'params'  => [
                 'id'          => $this->params->idPath(),
@@ -75,7 +75,7 @@ public function getSecurityGroup()
     {
         return [
             'method' => 'GET',
-            'path'   => $this->pathPrefix . 'security-groups/{id}',
+            'path'   => $this->pathPrefix . '/security-groups/{id}',
             'params' => [
                 'id' => $this->params->idPath(),
             ],
@@ -92,7 +92,7 @@ public function deleteSecurityGroup()
     {
         return [
             'method' => 'DELETE',
-            'path'   => $this->pathPrefix . 'security-groups/{id}',
+            'path'   => $this->pathPrefix . '/security-groups/{id}',
             'params' => [
                 'id' => $this->params->idPath(),
             ],
@@ -108,7 +108,7 @@ public function getSecurityRules()
     {
         return [
             'method' => 'GET',
-            'path'   => $this->pathPrefix . 'security-group-rules',
+            'path'   => $this->pathPrefix . '/security-group-rules',
             'params' => [],
         ];
     }
@@ -122,7 +122,7 @@ public function postSecurityRules()
     {
         return [
             'method'  => 'POST',
-            'path'    => $this->pathPrefix . 'security-group-rules',
+            'path'    => $this->pathPrefix . '/security-group-rules',
             'jsonKey' => 'security_group_rule',
             'params'  => [
                 'direction'       => $this->params->directionJson(),
@@ -147,7 +147,7 @@ public function deleteSecurityRule()
     {
         return [
             'method' => 'DELETE',
-            'path'   => $this->pathPrefix . 'security-group-rules/{id}',
+            'path'   => $this->pathPrefix . '/security-group-rules/{id}',
             'params' => [
                 'id' => $this->params->idPath(),
             ],
@@ -164,7 +164,7 @@ public function getSecurityRule()
     {
         return [
             'method' => 'GET',
-            'path'   => $this->pathPrefix . 'security-group-rules/{id}',
+            'path'   => $this->pathPrefix . '/security-group-rules/{id}',
             'params' => [
                 'id' => $this->params->idPath(),
             ],

tests/unit/Networking/v2/Extensions/SecurityGroups/Models/SecurityGroupRuleTest.php

@@ -24,14 +24,14 @@ public function setUp()
 
     public function test_it_deletes()
     {
-        $this->setupMock('DELETE', 'security-group-rules/id', null, [], new Response(202));
+        $this->setupMock('DELETE', '/v2.0/security-group-rules/id', null, [], new Response(202));
 
         $this->securityGroupRule->delete();
     }
 
     public function test_it_retrieves()
     {
-        $this->setupMock('GET', 'security-group-rules/id', null, [], 'SecurityGroupRule');
+        $this->setupMock('GET', '/v2.0/security-group-rules/id', null, [], 'SecurityGroupRule');
 
         $this->securityGroupRule->retrieve();
     }

tests/unit/Networking/v2/Extensions/SecurityGroups/Models/SecurityGroupTest.php

@@ -24,15 +24,44 @@ public function setUp()
 
     public function test_it_deletes()
     {
-        $this->setupMock('DELETE', 'security-groups/id', null, [], new Response(202));
+        $this->setupMock('DELETE', 'v2.0/security-groups/id', null, [], new Response(202));
 
         $this->securityGroup->delete();
     }
 
     public function test_it_retrieves()
     {
-        $this->setupMock('GET', 'security-groups/id', null, [], 'SecurityGroup');
+        $this->setupMock('GET', 'v2.0/security-groups/id', null, [], 'SecurityGroup');
 
         $this->securityGroup->retrieve();
     }
-}
+    
+    public function test_it_updates()
+    {
+        $this->setupMock('PUT', 'v2.0/security-groups/id', null, [], 'SecurityGroup');
+
+        $this->securityGroup->update();
+    }
+
+    public function test_it_creates()
+    {
+        $opts = [
+            'name'      => 'bar',
+            'description' => 'foo',
+        ];
+
+        $expectedJson = json_encode(
+            [
+                'security_group' => [
+                    'name'        => $opts['name'],
+                    'description' => $opts['description'],
+                ],
+            ],
+            JSON_UNESCAPED_SLASHES
+        );
+
+        $this->setupMock('POST', 'v2.0/security-groups', $expectedJson, ['Content-Type' => 'application/json'], 'SecurityGroup');
+
+        $this->assertInstanceOf(SecurityGroup::class, $this->securityGroup->create($opts));
+    }
+}