set alias for image list params, added sort param #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
k0ka
requested changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added alias/
sentAsdefinitions to some parameters of the ImagesV2getImages()function which was missing and also added thesortparameter. https://docs.openstack.org/api-ref/image/v2/index.html?expanded=list-images-detail#list-imagesThe
sortKeyandsortDirparameters are abstract and also used in the BlockStorageV2 API, but from what I could find they are not really supported there: https://docs.openstack.org/api-ref/block-storage/v2/?expanded=list-snapshots-with-details-detail#list-snapshots-with-detailsThey are supported in the backups method, but from what I could find, this is not implemented in this library: https://docs.openstack.org/api-ref/block-storage/v2/?expanded=list-backups-with-details-detail#list-backups-with-details
But they use the same alias there and the
sort_keyandsort_diralias follow the naming scheme, so I think it's safe to change it in the abstract class.