frankenphp: add frankenphp_loop_max option (#156)

See php/frankenphp#280.

Author: dunglas

src/frankenphp-symfony/CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Added
 
 - Add support for Symfony 7
+- Add `frankenphp_loop_max` option
 
 ## 0.1.0
 

src/frankenphp-symfony/README.md

@@ -36,3 +36,7 @@ return function (array $context) {
     return new Kernel($context['APP_ENV'], (bool) $context['APP_DEBUG']);
 };
 ```
+
+## Options
+
+* `frankenphp_loop_max`: the number of requests after which the worker must restart, to prevent weird memory leaks (default to `500`, set to `-1` to never restart)

src/frankenphp-symfony/src/Runner.php

@@ -16,8 +16,10 @@
  */
 class Runner implements RunnerInterface
 {
-    public function __construct(private HttpKernelInterface $kernel)
-    {
+    public function __construct(
+        private HttpKernelInterface $kernel,
+        private int $loopMax,
+    ) {
     }
 
     public function run(): int
@@ -38,6 +40,7 @@ public function run(): int
             $sfResponse->send();
         };
 
+        $loops = 0;
         do {
             $ret = \frankenphp_handle_request($handler);
 
@@ -46,7 +49,7 @@ public function run(): int
             }
 
             gc_collect_cycles();
-        } while ($ret);
+        } while ($ret && (-1 === $this->loopMax || ++$loops <= $this->loopMax));
 
         return 0;
     }

src/frankenphp-symfony/src/Runtime.php

@@ -15,10 +15,22 @@
  */
 class Runtime extends SymfonyRuntime
 {
+    /**
+     * @param array{
+     *   frankenphp_loop_max?: int,
+     * } $options
+     */
+    public function __construct(array $options = [])
+    {
+        $options['frankenphp_loop_max'] = (int) ($options['frankenphp_loop_max'] ?? $_SERVER['FRANKENPHP_LOOP_MAX'] ?? $_ENV['FRANKENPHP_LOOP_MAX'] ?? 500);
+
+        parent::__construct($options);
+    }
+
     public function getRunner(?object $application): RunnerInterface
     {
         if ($application instanceof HttpKernelInterface && ($_SERVER['FRANKENPHP_WORKER'] ?? false)) {
-            return new Runner($application);
+            return new Runner($application, $this->options['frankenphp_loop_max']);
         }
 
         return parent::getRunner($application);

src/frankenphp-symfony/tests/RunnerTest.php

@@ -37,7 +37,7 @@ public function testRun(): void
 
         $_SERVER['FOO'] = 'bar';
 
-        $runner = new Runner($application);
+        $runner = new Runner($application, 500);
         $this->assertSame(0, $runner->run());
     }
 }