Merge pull request #60 from openeuropa/GH-59

GH-59: Fix ObjectEncoder dropping attributes with falsy values

Author: veewee

src/Encoder/ObjectEncoder.php

@@ -103,7 +103,7 @@ static function (string $normalizePropertyName, Property $property) use ($object
                             $iso = $objectAccess->isos[$normalizePropertyName];
 
                             return match(true) {
-                                $isAttribute => $value ? (new AttributeBuilder(
+                                $isAttribute => $value !== null ? (new AttributeBuilder(
                                     $type,
                                     $iso->to($value)
                                 ))(...) : $defaultAction,

tests/Unit/Encoder/ObjectEncoderTest.php

@@ -109,6 +109,23 @@ public static function provideIsomorphicCases(): iterable
             'xml' => '<user active="true"><hat><color>green</color></hat></user>',
             'data' => new User(active: true, hat: new Hat('green')),
         ];
+        yield 'with-falsy-attribute' => [
+            ...$baseConfig,
+            'context' => self::createContext($xsdType, self::buildTypes(activeAsAttribute: true)),
+            'xml' => '<user active="false"><hat><color>green</color></hat></user>',
+            'data' => (object)[
+                'active' => false,
+                'hat' => (object)[
+                    'color' => 'green',
+                ],
+            ],
+        ];
+        yield 'class-objects-with-falsy-attribute' => [
+            'encoder' => new ObjectEncoder(User::class),
+            'context' => $withClassMap(self::createContext($xsdType, self::buildTypes(activeAsAttribute: true))),
+            'xml' => '<user active="false"><hat><color>green</color></hat></user>',
+            'data' => new User(active: false, hat: new Hat('green')),
+        ];
 
         yield 'wsdl-example-objects' => [
             ...$baseConfig,