fixed #4 command names to service definition

Author: wachterjohannes

CHANGELOG.md

@@ -0,0 +1,4 @@
+# CHANGELOG
+
+* dev-master
+    * ENHANCEMENT #- Moved command name to service definition   

src/Command/RunCommand.php

@@ -19,9 +19,9 @@ class RunCommand extends Command
      */
     private $scheduler;
 
-    public function __construct(SchedulerInterface $scheduler)
+    public function __construct($name, SchedulerInterface $scheduler)
     {
-        parent::__construct('task:run');
+        parent::__construct($name);
 
         $this->scheduler = $scheduler;
     }

src/Command/RunHandlerCommand.php

@@ -21,9 +21,9 @@ class RunHandlerCommand extends Command
      */
     private $registry;
 
-    public function __construct(RegistryInterface $registry)
+    public function __construct($name, RegistryInterface $registry)
     {
-        parent::__construct('task:run:handler');
+        parent::__construct($name);
 
         $this->registry = $registry;
     }

src/Command/ScheduleTaskCommand.php

@@ -20,9 +20,9 @@ class ScheduleTaskCommand extends Command
      */
     private $scheduler;
 
-    public function __construct(SchedulerInterface $scheduler)
+    public function __construct($name, SchedulerInterface $scheduler)
     {
-        parent::__construct('task:schedule:task');
+        parent::__construct($name);
 
         $this->scheduler = $scheduler;
     }

src/Resources/config/command.xml

@@ -4,18 +4,21 @@
            xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
     <services>
         <service id="task.command.run" class="Task\TaskBundle\Command\RunCommand">
+            <argument type="string">task:run</argument>
             <argument type="service" id="task.scheduler"/>
 
             <tag name="console.command"/>
         </service>
 
         <service id="task.command.run.handler" class="Task\TaskBundle\Command\RunHandlerCommand">
+            <argument type="string">task:run:handler</argument>
             <argument type="service" id="task.handler_registry"/>
 
             <tag name="console.command"/>
         </service>
 
         <service id="task.command.schedule_task" class="Task\TaskBundle\Command\ScheduleTaskCommand">
+            <argument type="string">task:schedule:task</argument>
             <argument type="service" id="task.scheduler"/>
 
             <tag name="console.command"/>

tests/Unit/Command/RunCommandTest.php

@@ -12,7 +12,7 @@ class RunCommandTest extends \PHPUnit_Framework_TestCase
     public function testConfigure()
     {
         $scheduler = $this->prophesize(SchedulerInterface::class);
-        $command = new RunCommand($scheduler->reveal());
+        $command = new RunCommand('task:run', $scheduler->reveal());
 
         $this->assertEquals('task:run', $command->getName());
     }
@@ -23,7 +23,7 @@ public function testRun()
         $output = $this->prophesize(OutputInterface::class);
 
         $scheduler = $this->prophesize(SchedulerInterface::class);
-        $command = new RunCommand($scheduler->reveal());
+        $command = new RunCommand('task:run', $scheduler->reveal());
 
         $command->run($input->reveal(), $output->reveal());
 

tests/Unit/Command/RunHandlerCommandTest.php

@@ -13,7 +13,7 @@ class RunHandlerCommandTest extends \PHPUnit_Framework_TestCase
     public function testConfigure()
     {
         $scheduler = $this->prophesize(RegistryInterface::class);
-        $command = new RunHandlerCommand($scheduler->reveal());
+        $command = new RunHandlerCommand('task:run:handler', $scheduler->reveal());
 
         $this->assertEquals('task:run:handler', $command->getName());
     }
@@ -43,7 +43,7 @@ public function testRun($handlerName, $workload)
         $input->getArgument('workload')->willReturn($workload);
 
         $registry = $this->prophesize(RegistryInterface::class);
-        $command = new RunHandlerCommand($registry->reveal());
+        $command = new RunHandlerCommand('task:run:handler', $registry->reveal());
 
         $command->run($input->reveal(), $output->reveal());
 

tests/Unit/Command/ScheduleTaskCommandTest.php

@@ -14,7 +14,7 @@ class ScheduleTaskCommandTest extends \PHPUnit_Framework_TestCase
     public function testConfigure()
     {
         $scheduler = $this->prophesize(SchedulerInterface::class);
-        $command = new ScheduleTaskCommand($scheduler->reveal());
+        $command = new ScheduleTaskCommand('task:schedule:task', $scheduler->reveal());
 
         $this->assertEquals('task:schedule:task', $command->getName());
         $this->assertTrue($command->getDefinition()->hasArgument('handler'));
@@ -48,7 +48,7 @@ public function testRun($handler, $workload)
         $input->getArgument('workload')->willReturn($workload);
 
         $scheduler = $this->prophesize(SchedulerInterface::class);
-        $command = new ScheduleTaskCommand($scheduler->reveal());
+        $command = new ScheduleTaskCommand('task:schedule:task', $scheduler->reveal());
 
         $scheduler->createTask($handler, $workload)->shouldBeCalledTimes(1)->willReturn($taskBuilder->reveal());