added testcases for run handler command and fixed code-style

Author: wachterjohannes

src/Command/RunHandlerCommand.php

@@ -12,7 +12,7 @@
 /**
  * Run pending tasks.
  *
- * @author @wachterjohannes <johannes.wachter@massiveart.com>
+ * @author Alexander Schranz <alexander.schranz@massiveart.com>
  */
 class RunHandlerCommand extends Command
 {
@@ -43,6 +43,13 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $this->registry->run($input->getArgument('handler'), $input->getArgument('workload'));
+        $handler = $input->getArgument('handler');
+        $workload = $input->getArgument('workload');
+
+        $output->writeln(sprintf('Run command "%s" with workload "%s"', $handler, $workload));
+
+        $result = $this->registry->run($handler, $workload);
+
+        $output->writeln(sprintf('Result: "%s"', $result));
     }
 }

tests/Unit/Command/RunHandlerCommandTest.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace Unit\Command;
+
+use Prophecy\Argument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Task\Handler\RegistryInterface;
+use Task\TaskBundle\Command\RunHandlerCommand;
+
+class RunHandlerCommandTest extends \PHPUnit_Framework_TestCase
+{
+    public function testConfigure()
+    {
+        $scheduler = $this->prophesize(RegistryInterface::class);
+        $command = new RunHandlerCommand($scheduler->reveal());
+
+        $this->assertEquals('task:run:handler', $command->getName());
+    }
+
+    public function runProvider()
+    {
+        return [
+            ['test-handler', 'test-workload'],
+            ['test-handler-1', 'test-workload-1'],
+        ];
+    }
+
+    /**
+     * @dataProvider runProvider
+     */
+    public function testRun($handlerName, $workload)
+    {
+        $input = $this->prophesize(InputInterface::class);
+        $output = $this->prophesize(OutputInterface::class);
+
+        $input->bind(Argument::any())->willReturn(true);
+        $input->validate()->willReturn(true);
+        $input->isInteractive()->willReturn(false);
+        $input->hasArgument('command')->willReturn(false);
+
+        $input->getArgument('handler')->willReturn($handlerName);
+        $input->getArgument('workload')->willReturn($workload);
+
+        $registry = $this->prophesize(RegistryInterface::class);
+        $command = new RunHandlerCommand($registry->reveal());
+
+        $command->run($input->reveal(), $output->reveal());
+
+        $registry->run($handlerName, $workload)->shouldBeCalledTimes(1);
+    }
+}

tests/Unit/DependencyInjection/TaskCompilerPassTest.php

@@ -57,39 +57,15 @@ public function testProcess()
 
         $schedulerDefinition->addMethodCall(
             TaskCompilerPass::CREATE_FUNCTION_NAME,
-            Argument::that(
-                function ($arguments) {
-                    return
-                        $arguments[0] === 'handler-1'
-                        && $arguments[1] === 'test-workload'
-                        && $arguments[2] === 'daily'
-                        && $arguments[3] === 'test-key';
-                }
-            )
+            ['handler-1', 'test-workload', 'daily', 'test-key']
         )->shouldBeCalledTimes(1);
         $schedulerDefinition->addMethodCall(
             TaskCompilerPass::CREATE_FUNCTION_NAME,
-            Argument::that(
-                function ($arguments) {
-                    return
-                        $arguments[0] === 'handler-2'
-                        && $arguments[1] === null
-                        && $arguments[2] === 'daily'
-                        && $arguments[3] === 'test-key';
-                }
-            )
+            ['handler-2', null, 'daily', 'test-key-1']
         )->shouldBeCalledTimes(1);
         $schedulerDefinition->addMethodCall(
             TaskCompilerPass::CREATE_FUNCTION_NAME,
-            Argument::that(
-                function ($arguments) {
-                    return
-                        $arguments[0] === 'handler-2'
-                        && $arguments[1] === 'test-workload-2'
-                        && $arguments[2] === 'daily'
-                        && $arguments[3] === 'handler-2_daily_s:15:"test-workload-2";';
-                }
-            )
+            ['handler-2', 'test-workload-2', 'daily', 'handler-2_daily_s:15:"test-workload-2";']
         )->shouldBeCalledTimes(1);
 
         // TODO this test always returns true should be extended

tests/Unit/Storage/DoctrineStorageTest.php

@@ -81,11 +81,24 @@ public function testStoreTaskForKeyExists($date, $completed, $uuid, $key = null)
             $oldTask = $this->prophesize(TaskInterface::class);
 
             $repository->findOneBy(['key' => $key, 'completed' => false])->willReturn($oldTask)->shouldBeCalledTimes(1);
+
+            $entityManager->persist(Argument::any())->shouldNotBeCalled();
+            $entityManager->flush()->shouldNotBeCalled();
+        } else {
+            $entityManager->persist(
+                Argument::that(
+                    function (TaskEntity $entity) use ($date, $completed, $uuid) {
+                        $this->assertEquals($uuid, $entity->getUuid());
+                        $this->assertEquals($completed, $entity->isCompleted());
+                        $this->assertEquals($date, $entity->getExecutionDate());
+
+                        return true;
+                    }
+                )
+            )->shouldBeCalledTimes(1);
+            $entityManager->flush()->shouldBeCalledTimes(1);
         }
 
         $storage->store($task->reveal());
-
-        $entityManager->persist(Argument::any())->shouldNotBeCalled();
-        $entityManager->flush()->shouldNotBeCalled();
     }
 }