chore(Bench): Cleanup

Author: roxblnfk

src/Application/Application.php

@@ -16,7 +16,6 @@
 use Testo\Application\Value\RunResult;
 use Testo\Common\Container;
 use Testo\Core\Value\Status;
-use Testo\Event\Framework\FrameworkStarting;
 use Testo\Event\Framework\SessionFinished;
 use Testo\Event\Framework\SessionStarting;
 use Testo\Event\Framework\WorkerFinished;
@@ -99,7 +98,7 @@ public function run(?Filter $filter = null): RunResult
         $suiteProvider = $this->container->get(SuiteProvider::class);
         $suiteRunner = $this->container->get(SuiteRunner::class);
         $status = Status::Passed;
-        $duration = microtime(true);
+        $duration = \microtime(true);
 
         # Iterate and run Test Suites
         $suiteResults = [];
@@ -108,7 +107,7 @@ public function run(?Filter $filter = null): RunResult
             $suiteResult->status->isFailure() and $status = Status::Failed;
         }
 
-        $duration = microtime(true) - $duration;
+        $duration = \microtime(true) - $duration;
         $result = new RunResult($suiteResults, status: $status, duration: $duration);
 
         $dispatcher->dispatch(new WorkerFinished());

src/Bench/Internal/BenchInvoker.php

@@ -13,6 +13,9 @@
 use Testo\Bench\Exception\BenchWithAttributeMissingException;
 use Testo\Core\Context\TestInfo;
 
+/**
+ * @internal
+ */
 final class BenchInvoker
 {
     public function __invoke(TestInfo $info): mixed
@@ -70,7 +73,7 @@ functions: $functions,
         $summaryTable = \Testo\Bench\Internal\Renderer::table($result);
         $itersTable = \Testo\Bench\Internal\Renderer::rounds($result);
         echo <<<EOT
-            Summary:
+            Results for {$info->name}:
             $summaryTable
 
             Iterations:

src/Bench/Internal/Calculator.php

@@ -9,6 +9,9 @@
 use Testo\Bench\Dto\Snap;
 use Testo\Inline\TestInline;
 
+/**
+ * @internal
+ */
 final class Calculator
 {
     /**

src/Bench/Internal/Explanator.php

@@ -10,6 +10,9 @@
 use Testo\Bench\Dto\Report;
 use Testo\Bench\Dto\ValueRel;
 
+/**
+ * @internal
+ */
 final class Explanator
 {
     /**
@@ -50,7 +53,7 @@ public static function prepareLines(array $cases, array $results): array
                 ),
                 frstdev: $result->frstdev,
                 rejected: $result->rejected,
-                reports: self::comment($result, $cases[$k]),
+                reports: self::explain($result, $cases[$k]),
             );
         }
 
@@ -59,14 +62,12 @@ public static function prepareLines(array $cases, array $results): array
         return $lines;
     }
 
-
     /**
      * Generates a comment for a given case result, potentially based on the presence of outliers or other factors.
      *
-     * @param CaseResult $result The result for which to generate the comment.
      * @return list<Report> A list of reports (comments, warnings, errors) related to the benchmark execution.
      */
-    private static function comment(CaseResult $caseResult, CaseSet $caseSet): array
+    private static function explain(CaseResult $caseResult, CaseSet $caseSet): array
     {
         $result = [];
 
@@ -83,7 +84,7 @@ private static function comment(CaseResult $caseResult, CaseSet $caseSet): array
             ? \abs($mean - $caseResult->med) / $caseResult->med * 100
             : 0.0;
 
-        // RStDev✓ × iter time
+        // RStDev* × iter time
         match (true) {
             $frstdev > 20.0 && $iterTime < 10.0 => $result[] = new Report\UnreliableLowIterTime($frstdev, $iterTime),
             $frstdev > 20.0 => $result[] = new Report\VeryHighVariance($frstdev),
@@ -99,7 +100,7 @@ private static function comment(CaseResult $caseResult, CaseSet $caseSet): array
             default => null,
         };
 
-        // |Mean✓ − Median| / Median
+        // |Mean* − Median| / Median
         match (true) {
             $skew > 10.0 => $result[] = new Report\HeavilySkewed($skew),
             $skew >= 5.0 => $result[] = new Report\SkewedDistribution($skew),
@@ -123,5 +124,4 @@ private static function comment(CaseResult $caseResult, CaseSet $caseSet): array
 
         return $result;
     }
-
 }

src/Bench/Internal/Renderer.php

@@ -112,44 +112,6 @@ public static function table(BenchResult $result): string
         return \implode("\n", $lines) . self::recommendations($result);
     }
 
-    private static function recommendations(BenchResult $result): string
-    {
-        $dangers = [];
-        $warnings = [];
-        $notices = [];
-
-        foreach ($result->lines as $line) {
-            foreach ($line->reports as $report) {
-                match ($report->severity) {
-                    Severity::Danger => $dangers[$report->reason] = $report->advice,
-                    Severity::Warning => $warnings[$report->reason] = $report->advice,
-                    Severity::Notice => $notices[$report->reason] = $report->advice,
-                    default => null,
-                };
-            }
-        }
-
-        if ($dangers === [] && $warnings === [] && $notices === []) {
-            return '';
-        }
-
-        $lines = ['', 'Recommendations:'];
-
-        foreach ($dangers as $reason => $advice) {
-            $lines[] = "  ✗ {$reason}: {$advice}";
-        }
-
-        foreach ($warnings as $reason => $advice) {
-            $lines[] = "  ⚠ {$reason}: {$advice}";
-        }
-
-        foreach ($notices as $reason => $advice) {
-            $lines[] = "  ℹ {$reason}: {$advice}";
-        }
-
-        return \implode("\n", $lines);
-    }
-
     public static function rounds(BenchResult $result): string
     {
         if ($result->cases === []) {
@@ -190,6 +152,44 @@ public static function rounds(BenchResult $result): string
         return \implode("\n", $lines);
     }
 
+    private static function recommendations(BenchResult $result): string
+    {
+        $dangers = [];
+        $warnings = [];
+        $notices = [];
+
+        foreach ($result->lines as $line) {
+            foreach ($line->reports as $report) {
+                match ($report->severity) {
+                    Severity::Danger => $dangers[$report->reason] = $report->advice,
+                    Severity::Warning => $warnings[$report->reason] = $report->advice,
+                    Severity::Notice => $notices[$report->reason] = $report->advice,
+                    default => null,
+                };
+            }
+        }
+
+        if ($dangers === [] && $warnings === [] && $notices === []) {
+            return '';
+        }
+
+        $lines = ['', 'Recommendations:'];
+
+        foreach ($dangers as $reason => $advice) {
+            $lines[] = "  ✗ {$reason}: {$advice}";
+        }
+
+        foreach ($warnings as $reason => $advice) {
+            $lines[] = "  ⚠ {$reason}: {$advice}";
+        }
+
+        foreach ($notices as $reason => $advice) {
+            $lines[] = "  ℹ {$reason}: {$advice}";
+        }
+
+        return \implode("\n", $lines);
+    }
+
     private static function formatMemory(float $bytes): string
     {
         if ($bytes === 0.0) {

src/Bridge/Symfony/Command/Base.php

@@ -110,5 +110,4 @@ protected function getConfigFile(InputInterface $input): ?Path
 
         return null;
     }
-
 }

src/Bridge/Symfony/TerminalRenderer.php

@@ -74,6 +74,11 @@ public function configure(Container $container): void
         $listeners->addListener(TestSuiteFinished::class, $this->onTestSuiteFinished(...));
     }
 
+    private static function getId(TestInfo $testInfo): string
+    {
+        return \spl_object_hash($testInfo->testDefinition);
+    }
+
     private function onSessionStarting(SessionStarting $event): void
     {
         $this->logger->ensureHeader();
@@ -85,11 +90,6 @@ private function onSessionFinished(SessionFinished $event): void
         $this->logger->printSummary($event->result->duration);
     }
 
-    private static function getId(TestInfo $testInfo): string
-    {
-        return \spl_object_hash($testInfo->testDefinition);
-    }
-
     private function onTestPipelineFinished(TestPipelineFinished $event): void
     {
         // Check if this test was inside a DataProvider batch

src/Common/Environment.php

@@ -19,23 +19,6 @@ final class Environment
 
     private function __construct() {}
 
-    private static function init(): void
-    {
-        static $skip = false;
-        if ($skip) {
-            return;
-        }
-
-        $skip = true;
-        self::$phpVersion = \phpversion();
-        self::$os = \php_uname('s') . ' ' . \php_uname('r');
-        self::$cpu = \php_uname('m');
-        self::$xDebugExists = \extension_loaded('xdebug');
-        self::$xDebugVersion = self::$xDebugExists ? \phpversion('xdebug') : null;
-        self::$opCacheEnabled = \extension_loaded('Zend OPcache') && \ini_get('opcache.enable_cli') === '1';
-        self::$jitEnabled = self::$opCacheEnabled && ((int) \ini_get('opcache.jit_buffer_size')) > 0;
-    }
-
     public static function getPhpVersion(): string
     {
         self::init();
@@ -90,4 +73,21 @@ public static function isJitEnabled(): bool
         self::init();
         return self::$jitEnabled;
     }
+
+    private static function init(): void
+    {
+        static $skip = false;
+        if ($skip) {
+            return;
+        }
+
+        $skip = true;
+        self::$phpVersion = \phpversion();
+        self::$os = \php_uname('s') . ' ' . \php_uname('r');
+        self::$cpu = \php_uname('m');
+        self::$xDebugExists = \extension_loaded('xdebug');
+        self::$xDebugVersion = self::$xDebugExists ? \phpversion('xdebug') : null;
+        self::$opCacheEnabled = \extension_loaded('Zend OPcache') && \ini_get('opcache.enable_cli') === '1';
+        self::$jitEnabled = self::$opCacheEnabled && ((int) \ini_get('opcache.jit_buffer_size')) > 0;
+    }
 }

src/Teamcity/Teamcity/TeamcityLogger.php

@@ -71,16 +71,6 @@ public function logEnvironment(): void
         $this->publish(Formatter::blockClosed('Environment'));
     }
 
-    private static function key(string $name): string
-    {
-        return "\033[36;1m{$name}:\033[0m ";
-    }
-
-    private static function dim(string $text): string
-    {
-        return "\033[2m{$text}\033[0m";
-    }
-
     /**
      * Publishes test suite started message using SuiteInfo.
      */
@@ -251,6 +241,16 @@ public function handleSingleTestResult(TestResult $result, ?int $duration = null
         };
     }
 
+    private static function key(string $name): string
+    {
+        return "\033[36;1m{$name}:\033[0m ";
+    }
+
+    private static function dim(string $text): string
+    {
+        return "\033[2m{$text}\033[0m";
+    }
+
     /**
      * Handles passed test status.
      *

src/Teamcity/TeamcityRenderer.php

@@ -61,14 +61,14 @@ public function configure(Container $container): void
         $listeners->addListener(TestSuiteFinished::class, $this->onTestSuiteFinished(...));
     }
 
-    private function onSessionStarting(SessionStarting $event): void
+    private static function getId(TestInfo $testInfo): string
     {
-        $this->logger->logEnvironment();
+        return \spl_object_hash($testInfo->testDefinition);
     }
 
-    private static function getId(TestInfo $testInfo): string
+    private function onSessionStarting(SessionStarting $event): void
     {
-        return \spl_object_hash($testInfo->testDefinition);
+        $this->logger->logEnvironment();
     }
 
     private function onTestPipelineFinished(TestPipelineFinished $event): void