Skip to content

Commit e884b68

Browse files
committed
upsome for todo
1 parent d354fed commit e884b68

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

src/AbstractFlags.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,11 +141,19 @@ abstract class AbstractFlags implements ParserInterface
141141
*/
142142
protected $settings = [
143143
'hasShorts' => false,
144+
// some setting for render help
144145
'argNameLen' => 12,
145146
'optNameLen' => 12,
146147
'descNlOnOptLen' => self::OPT_MAX_WIDTH,
147148
];
148149

150+
/**
151+
* Delay call validators after parsed. TODO
152+
*
153+
* @var bool
154+
*/
155+
protected $delayValidate = false;
156+
149157
// -------------------- settings for parse option --------------------
150158

151159
/**

src/Contract/ValueInterface.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,12 @@
77
*/
88
interface ValueInterface
99
{
10-
public function setValue();
10+
/**
11+
* @param mixed $value
12+
*
13+
* @return mixed
14+
*/
15+
public function setValue($value);
1116

1217
public function getValue();
1318
}

src/SFlags.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,6 @@ class SFlags extends AbstractFlags
3636
*/
3737
private static $std;
3838

39-
/**
40-
* @var callable
41-
* @psalm-var callable(mixed $value, string $type): mixed
42-
*/
43-
protected $valueFilter;
44-
4539
// ------------------------ opts ------------------------
4640

4741
/**
@@ -804,12 +798,4 @@ public function getOptDefines(): array
804798
{
805799
return $this->optDefines;
806800
}
807-
808-
/**
809-
* @param callable $valueFilter
810-
*/
811-
public function setValueFilter(callable $valueFilter): void
812-
{
813-
$this->valueFilter = $valueFilter;
814-
}
815801
}

0 commit comments

Comments
 (0)