Make sure we do not extract implicit labels form HiddenType (#92)

* Make sure we do not extract implicit labels form HiddenType

* cs

Author: Nyholm

src/Visitor/Php/Symfony/FormTypeLabelImplicit.php

@@ -34,13 +34,22 @@ public function enterNode(Node $node)
         if ($node instanceof Node\Expr\MethodCall
             && ('add' === (string) $node->name || 'create' === (string) $node->name)
             && $node->args[0]->value instanceof Node\Scalar\String_) {
+            $skipLabel = false;
+            // Check if the form type is "hidden"
+            if (count($node->args) >= 2) {
+                $type = $node->args[1]->value;
+                if ($type instanceof Node\Scalar\String_ && 'Symfony\Component\Form\Extension\Core\Type\HiddenType' === $type->value
+                    || $type instanceof Node\Expr\ClassConstFetch && 'HiddenType' === $type->class->parts[0]) {
+                    $skipLabel = true;
+                }
+            }
+
             // now make sure we don't have 'label' in the array of options
-            $customLabel = false;
             if (count($node->args) >= 3) {
                 if ($node->args[2]->value instanceof Node\Expr\Array_) {
                     foreach ($node->args[2]->value->items as $item) {
                         if (isset($item->key) && 'label' === $item->key->value) {
-                            $customLabel = true;
+                            $skipLabel = true;
                         }
 
                         if (isset($item->key) && 'translation_domain' === $item->key->value) {
@@ -58,7 +67,7 @@ public function enterNode(Node $node)
             }
 
             // only if no custom label was found, proceed
-            if (false === $customLabel && false !== $domain) {
+            if (false === $skipLabel && false !== $domain) {
                 $label = $node->args[0]->value->value;
                 if (!empty($label)) {
                     if (null !== $location = $this->getLocation($label, $node->getAttribute('startLine'), $node, ['domain' => $domain])) {

tests/Resources/Github/Issue_78.php

@@ -0,0 +1,17 @@
+<?php
+
+use Symfony\Component\Form\AbstractType;
+use Symfony\Component\Form\Extension\Core\Type\HiddenType;
+
+class EmptyValueType extends AbstractType
+{
+    public function buildForm(FormBuilderInterface $builder, array $options)
+    {
+        $builder
+            ->add('github.issue_78a', HiddenType::class, array(
+            ))
+            ->add('github.issue_78b', 'Symfony\Component\Form\Extension\Core\Type\HiddenType', array(
+            ));
+
+    }
+}

tests/Smoke/AllExtractorsTest.php

@@ -50,6 +50,8 @@ public function testNoException()
         $sc = $extractor->extract($finder);
         $this->translationExists($sc, 'trans.issue_34');
         $this->translationMissing($sc, 'trans.issue_62');
+        $this->translationMissing($sc, 'github.issue_78a');
+        $this->translationMissing($sc, 'github.issue_78b');
 
         $source = $this->translationExists($sc, 'github.issue_82a');
         $this->assertEquals('custom', $source->getContext()['domain']);