Added test for issue 68 (#69)

* Added test for issue 68

* Check for no errors

* Allow to ignore "false"

* style fix

Author: Nyholm

src/Visitor/Php/Symfony/FormTypeLabelExplicit.php

@@ -48,6 +48,13 @@ public function enterNode(Node $node)
                 continue;
             }
 
+            if ($item->value instanceof Node\Expr\ConstFetch) {
+                // This might be boolean "false"
+                if ('false' === $item->value->name->toString()) {
+                    continue;
+                }
+            }
+
             if (!$item->value instanceof Node\Scalar\String_) {
                 $this->addError($item, 'Form label is not a scalar string');
 

tests/Functional/Visitor/Php/Symfony/FormTypeLabelExplicitTest.php

@@ -40,4 +40,11 @@ public function testWillNotExtractTypeless()
         $collection = $this->getSourceLocations(new FormTypeLabelExplicit(), Resources\Php\Symfony\ExplicitLabelTypeless::class);
         $this->assertCount(0, $collection);
     }
+
+    public function testWithLabelFalse()
+    {
+        $collection = $this->getSourceLocations(new FormTypeLabelExplicit(), Resources\Php\Symfony\ExplicitLabelFalseType::class);
+        $this->assertEmpty($collection);
+        $this->assertEmpty($collection->getErrors(), 'Using label=>false should not render an error');
+    }
 }

tests/Resources/Php/Symfony/ExplicitLabelFalseType.php

@@ -0,0 +1,15 @@
+<?php
+
+use Symfony\Component\Form\AbstractType;
+use Translation\Extractor\Annotation\Ignore;
+
+class ExplicitLabelFalseType extends AbstractType
+{
+    public function buildForm(FormBuilderInterface $builder, array $options)
+    {
+        $builder
+            ->add('trans.issue_68', null, array(
+                'label' => false
+            ));
+    }
+}