Merge pull request #158 from cristoforocervino/symfony-placeholder-as-array

Add support to placeholders as array

Author: bocharsky-bw

src/Visitor/Php/Symfony/FormTypePlaceholder.php

@@ -94,6 +94,13 @@ public function enterNode(Node $node): ?Node
         } elseif ($placeholderNode->value instanceof Node\Expr\ConstFetch && 'false' === $placeholderNode->value->name->toString()) {
             // 'placeholder' => false,
             // Do noting
+        } elseif ($placeholderNode->value instanceof Node\Expr\Array_) {
+            foreach ($placeholderNode->value->items as $placeholderNode) {
+                $line = $placeholderNode->value->getAttribute('startLine');
+                if (null !== $location = $this->getLocation($placeholderNode->value->value, $line, $placeholderNode, ['domain' => $domain])) {
+                    $this->lateCollect($location);
+                }
+            }
         } else {
             $this->addError($placeholderNode, 'Form placeholder is not a scalar string');
         }

tests/Functional/Visitor/Php/Symfony/FormTypePlaceholderTest.php

@@ -26,10 +26,13 @@ public function testExtract()
         $collection = $this->getSourceLocations(new FormTypePlaceholder(),
             Resources\Php\Symfony\PlaceholderFormType::class);
 
-        $this->assertCount(3, $collection);
+        $this->assertCount(6, $collection);
         $this->assertEquals('form.placeholder.text', $collection->get(0)->getMessage());
         $this->assertEquals('form.placeholder.text.but.no.label', $collection->get(1)->getMessage());
         $this->assertEquals('form.choice_placeholder', $collection->get(2)->getMessage());
+        $this->assertEquals('form.date_placeholder.year', $collection->get(3)->getMessage());
+        $this->assertEquals('form.date_placeholder.month', $collection->get(4)->getMessage());
+        $this->assertEquals('form.date_placeholder.day', $collection->get(5)->getMessage());
     }
 
     public function testExtractError()

tests/Resources/Php/Symfony/PlaceholderFormType.php

@@ -18,9 +18,16 @@ public function buildForm(FormBuilderInterface $builder, array $options)
                 'label' => false,
                 'attr' => array('placeholder' => 'form.placeholder.text.but.no.label')
             ))
-            ->add('field_placeholder', 'choice', array(
+            ->add('choice_field_placeholder', 'choice', array(
                 'placeholder' => 'form.choice_placeholder'
             ))
+            ->add('date_field_placeholder', 'date', array(
+                'placeholder' => [
+                    'year' => 'form.date_placeholder.year',
+                    'month' => 'form.date_placeholder.month',
+                    'day' => 'form.date_placeholder.day'
+                ],
+            ))
         ;
     }
 }