Merge pull request #53 from php-translation/issue-51

Catch errors better.

Author: Nyholm

src/Visitor/Php/Symfony/ValidationAnnotation.php

@@ -11,6 +11,7 @@
 
 namespace Translation\Extractor\Visitor\Php\Symfony;
 
+use Doctrine\Common\Annotations\AnnotationException;
 use PhpParser\Node;
 use PhpParser\NodeVisitor;
 use Symfony\Component\Validator\Mapping\ClassMetadata;
@@ -69,8 +70,15 @@ public function enterNode(Node $node)
             return;
         }
 
-        /** @var ClassMetadata $metadata */
-        $metadata = $this->metadataFactory->getMetadataFor($name);
+        try {
+            /** @var ClassMetadata $metadata */
+            $metadata = $this->metadataFactory->getMetadataFor($name);
+        } catch (AnnotationException $e) {
+            $this->addError($node, 'Could not parse class "%s" for annotations. %s', $this->namespace, $e->getMessage());
+
+            return;
+        }
+
         if (!$metadata->hasConstraints() && !count($metadata->getConstrainedProperties())) {
             return;
         }

tests/Functional/Visitor/Php/Symfony/ValidationAnnotationTest.php

@@ -38,4 +38,14 @@ public function testExtractAnnotation()
         $this->assertEquals('end.blank', $source->getMessage());
         $this->assertEquals('validators', $source->getContext()['domain']);
     }
+
+    public function testExtractAnnotationError()
+    {
+        $factory = new LazyLoadingMetadataFactory(new AnnotationLoader(new AnnotationReader()));
+        $extractor = new ValidationAnnotation($factory);
+        $collection = $this->getSourceLocations($extractor, Resources\Php\Symfony\ValidatorAnnotationError::class);
+
+        $errors = $collection->getErrors();
+        $this->assertCount(1, $errors);
+    }
 }

tests/Resources/Php/Symfony/ValidatorAnnotationError.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Translation\Extractor\Tests\Resources\Php\Symfony;
+
+use Symfony\Component\Validator\Constraints as Assert;
+use Symfony\Component\Validator\Constraints\NotBlank;
+
+class ValidatorAnnotationError
+{
+    /**
+     * @foobar This should be an Error
+     */
+    private $foo;
+}