Apply fixes from StyleCI (#155)

Author: Nyholm

Catalogue/CatalogueCounter.php

@@ -69,11 +69,11 @@ public function getCatalogueStatistics(MessageCatalogueInterface $catalogue)
             foreach ($catalogue->all($domain) as $key => $text) {
                 $metadata = new Metadata($catalogue->getMetadata($key, $domain));
                 $state = $metadata->getState();
-                if ($state === 'new') {
+                if ('new' === $state) {
                     ++$result[$domain]['new'];
                 }
 
-                if ($state === 'obsolete') {
+                if ('obsolete' === $state) {
                     ++$result[$domain]['obsolete'];
                 }
 

Controller/SymfonyProfilerController.php

@@ -78,7 +78,7 @@ public function syncAction(Request $request, $token)
         $sfMessage = $this->getMessage($request, $token);
         $message = $storage->syncAndFetchMessage($sfMessage->getLocale(), $sfMessage->getDomain(), $sfMessage->getKey());
 
-        if ($message !== null) {
+        if (null !== $message) {
             return new Response($message->getTranslation());
         }
 
@@ -165,7 +165,7 @@ private function getMessage(Request $request, $token)
         }
         $message = SfProfilerMessage::create($messages[$messageId]);
 
-        if ($message->getState() === DataCollectorTranslator::MESSAGE_EQUALS_FALLBACK) {
+        if (DataCollectorTranslator::MESSAGE_EQUALS_FALLBACK === $message->getState()) {
             $message->setLocale($profile->getCollector('request')->getLocale())
                 ->setTranslation(sprintf('[%s]', $message->getTranslation()));
         }
@@ -185,7 +185,7 @@ protected function getSelectedMessages(Request $request, $token)
         $profiler->disable();
 
         $selected = $request->request->get('selected');
-        if (!$selected || count($selected) == 0) {
+        if (!$selected || 0 == count($selected)) {
             return [];
         }
 

DependencyInjection/TranslationExtension.php

@@ -88,7 +88,7 @@ private function handleConfigNode(ContainerBuilder $container, array $config)
         // $first will be the "default" configuration.
         $first = null;
         foreach ($config['configs'] as $name => &$c) {
-            if ($first === null || $name === 'default') {
+            if (null === $first || 'default' === $name) {
                 $first = $name;
             }
             if (empty($c['project_root'])) {
@@ -115,7 +115,7 @@ private function handleConfigNode(ContainerBuilder $container, array $config)
             }
 
             foreach ($c['local_storage'] as $serviceId) {
-                if ($serviceId !== 'php_translation.local_file_storage.abstract') {
+                if ('php_translation.local_file_storage.abstract' !== $serviceId) {
                     $storageDefinition->addMethodCall('addLocalStorage', [new Reference($serviceId)]);
 
                     continue;
@@ -129,10 +129,10 @@ private function handleConfigNode(ContainerBuilder $container, array $config)
             }
         }
 
-        if ($first !== null) {
+        if (null !== $first) {
             // Create some aliases for the default storage
             $container->setAlias('php_translation.storage', 'php_translation.storage.'.$first);
-            if ($first !== 'default') {
+            if ('default' !== $first) {
                 $container->setAlias('php_translation.storage.default', 'php_translation.storage.'.$first);
             }
         }
@@ -172,7 +172,7 @@ private function enableEditInPlace(ContainerBuilder $container, array $config)
     {
         $name = $config['edit_in_place']['config_name'];
 
-        if ($name !== 'default' && !isset($config['configs'][$name])) {
+        if ('default' !== $name && !isset($config['configs'][$name])) {
             throw new InvalidArgumentException(sprintf('There is no config named "%s".', $name));
         }
 

EventListener/AutoAddMissingTranslations.php

@@ -43,13 +43,13 @@ public function __construct(StorageService $storage, DataCollectorTranslator $tr
 
     public function onTerminate(Event $event)
     {
-        if ($this->dataCollector === null) {
+        if (null === $this->dataCollector) {
             return;
         }
 
         $messages = $this->dataCollector->getCollectedMessages();
         foreach ($messages as $message) {
-            if ($message['state'] === DataCollectorTranslator::MESSAGE_MISSING) {
+            if (DataCollectorTranslator::MESSAGE_MISSING === $message['state']) {
                 $m = new Message($message['id'], $message['domain'], $message['locale'], $message['translation']);
                 $this->storage->create($m);
             }

Model/CatalogueMessage.php

@@ -135,7 +135,7 @@ public function isNew()
             return false;
         }
 
-        return $this->metadata->getState() === 'new';
+        return 'new' === $this->metadata->getState();
     }
 
     public function isObsolete()
@@ -144,7 +144,7 @@ public function isObsolete()
             return false;
         }
 
-        return $this->metadata->getState() === 'obsolete';
+        return 'obsolete' === $this->metadata->getState();
     }
 
     public function isApproved()

Model/Metadata.php

@@ -73,7 +73,7 @@ public function isApproved()
         $notes = $this->getAllInCategory('approved');
         foreach ($notes as $note) {
             if (isset($note['content'])) {
-                return $note['content'] === 'true';
+                return 'true' === $note['content'];
             }
         }
 

Service/ConfigurationManager.php

@@ -49,7 +49,7 @@ public function getConfiguration($name = null)
             return $this->configuration[$name];
         }
 
-        if ($name === 'default') {
+        if ('default' === $name) {
             $name = $this->getFirstName();
             if (isset($this->configuration[$name])) {
                 return $this->configuration[$name];

Service/StorageService.php

@@ -28,6 +28,7 @@
 final class StorageService implements Storage
 {
     const DIRECTION_UP = 'up';
+
     const DIRECTION_DOWN = 'down';
 
     /**

Tests/Functional/Command/ExtractCommandTest.php

@@ -93,15 +93,15 @@ public function testExecute()
 
         // Test meta, source-location
         $meta = new Metadata($catalogue->getMetadata('translated.paragraph1'));
-        $this->assertFalse($meta->getState() === 'new');
+        $this->assertFalse('new' === $meta->getState());
         foreach ($meta->getSourceLocations() as $sourceLocation) {
             $this->assertNotEquals('foobar.html.twig', $sourceLocation['path']);
         }
 
         $meta = new Metadata($catalogue->getMetadata('not.in.source'));
-        $this->assertTrue($meta->getState() === 'obsolete');
+        $this->assertTrue('obsolete' === $meta->getState());
 
         $meta = new Metadata($catalogue->getMetadata('translated.title'));
-        $this->assertTrue($meta->getState() === 'new');
+        $this->assertTrue('new' === $meta->getState());
     }
 }

Translator/FallbackTranslator.php

@@ -151,7 +151,7 @@ private function translateWithSubstitutedParameters($orgString, $locale, array $
         $replacedString = str_replace(array_keys($replacements), array_values($replacements), $orgString);
         $translatedString = $this->externalTranslator->translate($replacedString, $this->defaultLocale, $locale);
 
-        if ($translatedString === null) {
+        if (null === $translatedString) {
             // Could not be translated
             return $orgString;
         }