prevent the builder from creating invalid clients

Author: xabbuh

CHANGELOG.md

@@ -4,6 +4,10 @@ CHANGELOG
 0.3.0
 -----
 
+* Fixed creating `XApiClient` instances in an invalid state. The `XApiClientBuilder`
+  now throws a `\LogicException` when the `build()` method is called before
+  a base URI was configured.
+
 * Removed the `ApiClient` class. The `$requestHandler` and `$version` attributes
   have been moved to the former child classes of the `ApiClient` class and
   their visibility has been changed to `private`.

spec/XApiClientBuilderSpec.php

@@ -13,6 +13,12 @@ function it_is_an_xapi_client_builder()
 
     function it_creates_an_xapi_client()
     {
+        $this->setBaseUrl('http://example.com/xapi/');
         $this->build()->shouldHaveType('Xabbuh\XApi\Client\XApiClientInterface');
     }
+
+    function it_throws_an_exception_if_the_base_uri_is_not_configured()
+    {
+        $this->shouldThrow('\LogicException')->during('build');
+    }
 }

src/XApiClientBuilder.php

@@ -89,6 +89,10 @@ public function setOAuthCredentials($consumerKey, $consumerSecret, $token, $toke
      */
     public function build()
     {
+        if (null === $this->baseUrl) {
+            throw new \LogicException('Base URI value was not configured.');
+        }
+
         $httpClient = new Client($this->baseUrl);
 
         if (is_array($this->oAuthCredentials)) {

src/XApiClientBuilderInterface.php

@@ -62,6 +62,8 @@ public function setOAuthCredentials($consumerKey, $consumerSecret, $token, $toke
      * Builds the xAPI client.
      *
      * @return XApiClientInterface The xAPI client
+     *
+     * @throws \LogicException if no base URI was configured
      */
     public function build();
 }