send auth credentials only when necessary

Author: xabbuh

CHANGELOG.md

@@ -4,6 +4,8 @@ CHANGELOG
 0.3.0
 -----
 
+* Do not send authentication headers when no credentials have been configured.
+
 * Fixed treating HTTP methods case insensitive. Rejecting uppercased HTTP
   method names contradicts the HTTP specification. Lowercased method names
   will still be supported to keep backwards compatibility though.

spec/Request/HandlerSpec.php

@@ -24,7 +24,18 @@ function it_sets_the_experience_api_version_header_and_the_content_type_header_w
         $client->get('/xapi/statements')->willReturn($request);
         $request->addHeader('X-Experience-API-Version', '1.0.1')->shouldBeCalled();
         $request->addHeader('Content-Type', 'application/json')->shouldBeCalled();
-        $request->setAuth(null, null)->shouldBeCalled();
+
+        $this->createRequest('get', '/xapi/statements');
+    }
+
+    function it_sets_basic_auth_data_when_credentials_are_configured_when_creating_a_request(ClientInterface $client, RequestInterface $request)
+    {
+        $this->beConstructedWith($client, '1.0.1', 'username', 'password');
+
+        $client->get('/xapi/statements')->willReturn($request);
+        $request->addHeader('X-Experience-API-Version', '1.0.1')->shouldBeCalled();
+        $request->addHeader('Content-Type', 'application/json')->shouldBeCalled();
+        $request->setAuth('username', 'password')->shouldBeCalled();
 
         $this->createRequest('get', '/xapi/statements');
     }

src/Request/Handler.php

@@ -78,7 +78,10 @@ public function createRequest($method, $uri, array $urlParameters = array(), $bo
 
         $request->addHeader('X-Experience-API-Version', $this->version);
         $request->addHeader('Content-Type', 'application/json');
-        $request->setAuth($this->username, $this->password);
+
+        if (null !== $this->username && null !== $this->password) {
+            $request->setAuth($this->username, $this->password);
+        }
 
         return $request;
     }