statement ids have to be UUIDs

Author: xabbuh

Tests/Model/StatementTest.php

@@ -31,7 +31,7 @@ public function testValidateMinimalStatement()
     public function testValidStatement()
     {
         $statement = new Statement();
-        $statement->setId(md5(uniqid()));
+        $statement->setId('12345678-1234-5678-8234-567812345678');
         $statement->setActor(new Agent());
         $statement->setVerb(new Verb());
         $statement->setObject(new Activity());
@@ -49,10 +49,21 @@ public function testWithoutId()
         $this->validateStatement($statement, 1);
     }
 
+    public function testNotUuidIdInvalidates()
+    {
+        $statement = new Statement();
+        $statement->setId('foo');
+        $statement->setActor(new Agent());
+        $statement->setVerb(new Verb());
+        $statement->setObject(new Activity());
+
+        $this->validateStatement($statement, 1);
+    }
+
     public function testWithoutActor()
     {
         $statement = new Statement();
-        $statement->setId(md5(uniqid()));
+        $statement->setId('12345678-1234-5678-8234-567812345678');
         $statement->setVerb(new Verb());
         $statement->setObject(new Activity());
 
@@ -62,7 +73,7 @@ public function testWithoutActor()
     public function testWithoutVerb()
     {
         $statement = new Statement();
-        $statement->setId(md5(uniqid()));
+        $statement->setId('12345678-1234-5678-8234-567812345678');
         $statement->setActor(new Agent());
         $statement->setObject(new Activity());
 
@@ -72,7 +83,7 @@ public function testWithoutVerb()
     public function testWithoutObject()
     {
         $statement = new Statement();
-        $statement->setId(md5(uniqid()));
+        $statement->setId('12345678-1234-5678-8234-567812345678');
         $statement->setActor(new Agent());
         $statement->setVerb(new Verb());
 

Tests/Model/fixtures/minimal_statement.json

@@ -1,5 +1,5 @@
 {
-    "id": "12345678-1234-5678-1234-567812345678",
+    "id": "12345678-1234-5678-8234-567812345678",
     "actor": {
         "mbox": "mailto:[email protected]",
         "objectType": "Agent"

Tests/Serializer/StatementSerializerTest.php

@@ -44,7 +44,7 @@ public function testDeserializeMinimalStatement()
         );
 
         $this->assertEquals(
-            '12345678-1234-5678-1234-567812345678',
+            '12345678-1234-5678-8234-567812345678',
             $statement->getId()
         );
         $this->assertEquals(
@@ -157,7 +157,7 @@ public function testDeserializeWithResult()
     public function testSerializeMinimalStatement()
     {
         $statement = new Statement();
-        $statement->setId('12345678-1234-5678-1234-567812345678');
+        $statement->setId('12345678-1234-5678-8234-567812345678');
 
         $actor = new Agent();
         $actor->setMbox('mailto:[email protected]');

composer.json

@@ -15,7 +15,7 @@
         "php": ">=5.3.0",
         "jms/serializer": "~0.16",
         "symfony/config": "~2.2",
-        "symfony/validator": "~2.2"
+        "symfony/validator": "~2.5"
     },
     "require-dev": {
         "symfony/property-access": "~2.2"

metadata/validator/Statement.xml

@@ -7,6 +7,7 @@
     <class name="Xabbuh\XApi\Common\Model\Statement">
         <property name="id">
             <constraint name="NotBlank" />
+            <constraint name="Uuid" />
         </property>
         <property name="actor">
             <constraint name="NotBlank" />