minor #71 remove deprecated methods (xabbuh)

This PR was merged into the 3.0.x-dev branch.

Discussion
----------

remove deprecated methods

Commits
-------

19b7120 remove deprecated methods

Author: xabbuh

CHANGELOG.md

@@ -4,6 +4,14 @@ CHANGELOG
 3.0.0
 -----
 
+* The `Statement::getTimestamp()` method has been removed. Use
+  `Statement::getCreated()` instead.
+* The `Statement::withTimestamp()` method has been removed. Use
+  `Statement::withCreated()` instead.
+* The `SubStatement::getTimestamp()` method has been removed. Use
+  `SubStatement::getCreated()` instead.
+* The `SubStatement::withTimestamp()` method has been removed. Use
+  `SubStatement::withCreated()` instead.
 * Dropped support for PHP < 7.1 as well as HHVM.
 * The `Object` class was renamed to `StatementObject` for compatibility with PHP
   7.2.

spec/StatementSpec.php

@@ -188,16 +188,6 @@ public function it_returns_a_new_instance_with_authority()
         $statement->getAuthority()->shouldReturn($authority);
     }
 
-    public function it_returns_a_new_instance_with_timestamp()
-    {
-        $timestamp = new \DateTime('2014-07-23T12:34:02-05:00');
-        $statement = $this->withTimestamp($timestamp);
-
-        $statement->shouldNotBe($this);
-        $statement->shouldBeAnInstanceOf('\Xabbuh\XApi\Model\Statement');
-        $statement->getTimestamp()->shouldReturn($timestamp);
-    }
-
     public function it_returns_a_new_instance_with_stored()
     {
         $stored = new \DateTime('2014-07-23T12:34:02-05:00');

spec/SubStatementSpec.php

@@ -165,16 +165,6 @@ public function it_returns_a_new_instance_with_result()
         $subStatement->getResult()->shouldReturn($result);
     }
 
-    public function it_returns_a_new_instance_with_timestamp()
-    {
-        $timestamp = new \DateTime('2014-07-23T12:34:02-05:00');
-        $statement = $this->withTimestamp($timestamp);
-
-        $statement->shouldNotBe($this);
-        $statement->shouldBeAnInstanceOf('\Xabbuh\XApi\Model\SubStatement');
-        $statement->getTimestamp()->shouldReturn($timestamp);
-    }
-
     public function it_returns_a_new_instance_with_context()
     {
         $context = new Context();

src/Statement.php

@@ -151,19 +151,6 @@ public function withAuthority(Actor $authority = null)
         return $statement;
     }
 
-    /**
-     * @deprecated since 1.2, to be removed in 3.0
-     */
-    public function withTimestamp(\DateTime $timestamp = null)
-    {
-        @trigger_error(sprintf('The "%s()" method is deprecated since 1.2 and will be removed in 3.0. Use "%s::withCreated()" instead.', __METHOD__, __CLASS__), E_USER_DEPRECATED);
-
-        $statement = clone $this;
-        $statement->created = $timestamp;
-
-        return $statement;
-    }
-
     public function withCreated(\DateTime $created = null)
     {
         $statement = clone $this;
@@ -274,21 +261,6 @@ public function getAuthority()
         return $this->authority;
     }
 
-    /**
-     * Returns the timestamp of when the events described in this statement
-     * occurred.
-     *
-     * @return \DateTime The timestamp
-     *
-     * @deprecated since 1.2, to be removed in 3.0
-     */
-    public function getTimestamp()
-    {
-        @trigger_error(sprintf('The "%s()" method is deprecated since 1.2 and will be removed in 3.0. Use "%s::getCreated()" instead.', __METHOD__, __CLASS__), E_USER_DEPRECATED);
-
-        return $this->created;
-    }
-
     /**
      * Returns the timestamp of when the events described in this statement
      * occurred.

src/SubStatement.php

@@ -97,19 +97,6 @@ public function withResult(Result $result)
         return $subStatement;
     }
 
-    /**
-     * @deprecated since 1.2, to be removed in 3.0
-     */
-    public function withTimestamp(\DateTime $timestamp = null)
-    {
-        @trigger_error(sprintf('The "%s()" method is deprecated since 1.2 and will be removed in 3.0. Use "%s::withCreated()" instead.', __METHOD__, __CLASS__), E_USER_DEPRECATED);
-
-        $statement = clone $this;
-        $statement->created = $timestamp;
-
-        return $statement;
-    }
-
     public function withCreated(\DateTime $created = null)
     {
         $statement = clone $this;
@@ -179,21 +166,6 @@ public function getResult()
         return $this->result;
     }
 
-    /**
-     * Returns the timestamp of when the events described in this statement
-     * occurred.
-     *
-     * @return \DateTime The timestamp
-     *
-     * @deprecated since 1.2, to be removed in 3.0
-     */
-    public function getTimestamp()
-    {
-        @trigger_error(sprintf('The "%s()" method is deprecated since 1.2 and will be removed in 3.0. Use "%s::getCreated()" instead.', __METHOD__, __CLASS__), E_USER_DEPRECATED);
-
-        return $this->created;
-    }
-
     /**
      * Returns the timestamp of when the events described in this statement
      * occurred.