Fix constructorsynopsis and destructorsynopsis validation (#84)

Co-authored-by: Christoph M. Becker <[email protected]>

Author: kocsismate

scripts/qa/section-order.php

@@ -177,8 +177,8 @@ function checkSectionErrors(string $path): array
 
     /* Constructors are special */
     if (str_ends_with($path, 'construct.xml')) {
-        if (!str_contains($content, '<constructorsynopsis>')
-            && !str_contains($content, '<constructorsynopsis role="oop">')
+        if (!str_contains($content, '<constructorsynopsis>') &&
+            !preg_match('/<constructorsynopsis role="[^"]*">/', $content)
         ) {
             // This generates a lot of errors leave for later
             //return ["Constructors should use <constructorsynopsis> instead of <methodsynopsis>"];
@@ -191,7 +191,8 @@ function checkSectionErrors(string $path): array
     }
     /* Destructors are special */
     if (str_ends_with($path, 'destruct.xml')) {
-        if (!str_contains($content, '<destructorsynopsis>')) {
+        if (!str_contains($content, '<destructorsynopsis>') &&
+            !preg_match('/<destructorsynopsis role="[^"]*">/', $content)) {
             // Early bail-out
             return ["Destructors should use <destructorsynopsis> instead of <methodsynopsis>"];
         }