Skip to content

[PHP 8.1] Documentation for full_path entry of $_FILES #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2021
Merged

[PHP 8.1] Documentation for full_path entry of $_FILES #1130

merged 3 commits into from
Dec 10, 2021

Conversation

saundefined
Copy link
Member

Add documentation for full_path entry, introduced in PHP 8.1.

@saundefined saundefined added this to the PHP 8.1 milestone Nov 23, 2021
@saundefined saundefined mentioned this pull request Nov 23, 2021
Closed
Alfreddo12
Alfreddo12 approved these changes Nov 23, 2021
View reviewed changes
Copy link

@Alfreddo12 Alfreddo12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #

@mumumu
Copy link
Member

mumumu commented Dec 8, 2021

impl: php/php-src#6917

cmb69
cmb69 reviewed Dec 8, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This looks good to me, but maybe we want to add a warning that
webkitdirectory is non-standard etc. like on https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/webkitdirectory.

mumumu
mumumu reviewed Dec 8, 2021
View reviewed changes
saundefined and others added 2 commits December 9, 2021 09:18
@saundefined
Copy link
Member Author

Thanks! Added a warning about it

@saundefined saundefined merged commit 92673cc into php:master Dec 10, 2021
@saundefined saundefined deleted the php81-file-upload-full-path branch December 10, 2021 07:16
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Dec 12, 2021
@saundefined @mumumu
@cmb69 @tiffany-taylor
[PHP 8.1] Documentation for full_path entry of $_FILES (php#1130)
a71c9b8 
Co-authored-by: Yoshinari Takaoka <[email protected]>
Co-authored-by: Christoph M. Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@mumumu mumumu mumumu approved these changes

+1 more reviewer

@Alfreddo12 Alfreddo12 Alfreddo12 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.1
Development

Successfully merging this pull request may close these issues.
5 participants
@saundefined @mumumu @cmb69 @Alfreddo12 @afilina