From eb383a2228e53d4f2c5e608eb75873d1af61d85d Mon Sep 17 00:00:00 2001
From: Gina Peter Banyard <girgias@php.net>
Date: Mon, 11 Nov 2024 03:39:43 +0000
Subject: [PATCH 1/4] PHP-8.4: Document fpow()

---
 reference/math/functions/fdiv.xml |   4 +-
 reference/math/functions/fpow.xml | 108 ++++++++++++++++++++++++++++++
 reference/math/functions/pow.xml  |   1 +
 reference/math/versions.xml       |   1 +
 4 files changed, 112 insertions(+), 2 deletions(-)
 create mode 100644 reference/math/functions/fpow.xml

diff --git a/reference/math/functions/fdiv.xml b/reference/math/functions/fdiv.xml
index c75b2e1487d1..f05efef8f086 100644
--- a/reference/math/functions/fdiv.xml
+++ b/reference/math/functions/fdiv.xml
@@ -76,9 +76,9 @@ var_dump(fdiv(0.0, 0.0)); // float(NAN)
   &reftitle.seealso;
   <para>
    <simplelist>
-    <member><link linkend="language.operators.arithmetic"><literal>/</literal></link> - Floating-point division</member>
     <member><function>intdiv</function> - Integer division</member>
-    <member><function>fmod</function> - Modulus</member>
+    <member><function>fmod</function></member>
+    <member><function>fpow</function></member>
    </simplelist>
   </para>
  </refsect1>
diff --git a/reference/math/functions/fpow.xml b/reference/math/functions/fpow.xml
new file mode 100644
index 000000000000..9e3335397260
--- /dev/null
+++ b/reference/math/functions/fpow.xml
@@ -0,0 +1,108 @@
+<?xml version="1.0" encoding="utf-8"?>
+<refentry xml:id="function.fpow" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <refnamediv>
+  <refname>fpow</refname>
+  <refpurpose>Raise one number to the power of another, according to IEEE 754</refpurpose>
+ </refnamediv>
+
+ <refsect1 role="description">
+  &reftitle.description;
+  <methodsynopsis>
+   <type>float</type><methodname>fpow</methodname>
+   <methodparam><type>float</type><parameter>num</parameter></methodparam>
+   <methodparam><type>float</type><parameter>exponent</parameter></methodparam>
+  </methodsynopsis>
+  <simpara>
+   Returns the floating point result of raising
+   <parameter>num1</parameter> to the power of <parameter>exponent</parameter>.
+   If <parameter>num1</parameter> is zero and <parameter>exponent</parameter>
+   is less than zero, then <constant>INF</constant> is returned.
+  </simpara>
+ </refsect1>
+
+ <refsect1 role="parameters">
+  &reftitle.parameters;
+  <variablelist>
+   <varlistentry>
+    <term><parameter>num</parameter></term>
+    <listitem>
+     <simpara>
+      The base to number.
+     </simpara>
+    </listitem>
+   </varlistentry>
+   <varlistentry>
+    <term><parameter>exponent</parameter></term>
+    <listitem>
+     <simpara>
+      The exponent.
+     </simpara>
+    </listitem>
+   </varlistentry>
+  </variablelist>
+ </refsect1>
+
+ <refsect1 role="returnvalues">
+  &reftitle.returnvalues;
+  <simpara>
+   Returns a <type>float</type> corresponding to
+   <code><parameter>num</parameter><superscript>$exponent</superscript></code>.
+  </simpara>
+ </refsect1>
+
+ <refsect1 role="examples">
+  &reftitle.examples;
+  <example xml:id="function.fpow.example.basic">
+   <title><function>fpow</function> example</title>
+   <programlisting role="php">
+<![CDATA[
+<?php
+var_dump(fpow(0, -3));
+var_dump(fpow(-1, 5.5));
+?>
+]]>
+   </programlisting>
+   &example.outputs;
+   <screen>
+<![CDATA[
+float(INF)
+float(NAN)
+]]>
+   </screen>
+  </example>
+ </refsect1>
+
+ <refsect1 role="seealso">
+  &reftitle.seealso;
+  <simplelist>
+   <member><link linkend="language.operators.arithmetic"><literal>/</literal></link> - Floating-point division</member>
+   <member><function>pow</function></member>
+   <member><function>fdiv</function></member>
+   <member><function>fmod</function></member>
+   <!-- TODO ** operator link?
+   <member><link linkend="some.id.chunk.to.link">something appendix</link></member>
+   -->
+  </simplelist>
+ </refsect1>
+
+</refentry>
+<!-- Keep this comment at the end of the file
+Local variables:
+mode: sgml
+sgml-omittag:t
+sgml-shorttag:t
+sgml-minimize-attributes:nil
+sgml-always-quote-attributes:t
+sgml-indent-step:1
+sgml-indent-data:t
+indent-tabs-mode:nil
+sgml-parent-document:nil
+sgml-default-dtd-file:"~/.phpdoc/manual.ced"
+sgml-exposed-tags:nil
+sgml-local-catalogs:nil
+sgml-local-ecat-files:nil
+End:
+vim600: syn=xml fen fdm=syntax fdl=2 si
+vim: et tw=78 syn=sgml
+vi: ts=1 sw=1
+-->
diff --git a/reference/math/functions/pow.xml b/reference/math/functions/pow.xml
index e32338103b4e..7788e11c247f 100644
--- a/reference/math/functions/pow.xml
+++ b/reference/math/functions/pow.xml
@@ -95,6 +95,7 @@ echo pow(-1, 5.5); // NAN
   &reftitle.seealso;
   <para>
    <simplelist>
+    <member><function>fpow</function></member>
     <member><function>exp</function></member>
     <member><function>sqrt</function></member>
     <member><function>bcpow</function></member>
diff --git a/reference/math/versions.xml b/reference/math/versions.xml
index 0429d661a3aa..f3688e13677d 100644
--- a/reference/math/versions.xml
+++ b/reference/math/versions.xml
@@ -26,6 +26,7 @@
  <function name="fdiv" from="PHP 8"/>
  <function name="floor" from="PHP 4, PHP 5, PHP 7, PHP 8"/>
  <function name="fmod" from="PHP 4 &gt;= 4.2.0, PHP 5, PHP 7, PHP 8"/>
+ <function name="fpow" from="PHP 8 &gt;= 8.4.0"/>
  <function name="hexdec" from="PHP 4, PHP 5, PHP 7, PHP 8"/>
  <function name="hypot" from="PHP 4 &gt;= 4.1.0, PHP 5, PHP 7, PHP 8"/>
  <function name="is_finite" from="PHP 4 &gt;= 4.2.0, PHP 5, PHP 7, PHP 8"/>

From 1eff2bba9b85762df1a59c01822fa77724e3bd24 Mon Sep 17 00:00:00 2001
From: Gina Peter Banyard <girgias@php.net>
Date: Tue, 12 Nov 2024 14:12:00 +0000
Subject: [PATCH 2/4] Apply suggestions from code review

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
---
 reference/math/functions/fpow.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/reference/math/functions/fpow.xml b/reference/math/functions/fpow.xml
index 9e3335397260..8341d120e9d2 100644
--- a/reference/math/functions/fpow.xml
+++ b/reference/math/functions/fpow.xml
@@ -14,8 +14,8 @@
   </methodsynopsis>
   <simpara>
    Returns the floating point result of raising
-   <parameter>num1</parameter> to the power of <parameter>exponent</parameter>.
-   If <parameter>num1</parameter> is zero and <parameter>exponent</parameter>
+   <parameter>num</parameter> to the power of <parameter>exponent</parameter>.
+   If <parameter>num</parameter> is zero and <parameter>exponent</parameter>
    is less than zero, then <constant>INF</constant> is returned.
   </simpara>
  </refsect1>
@@ -46,7 +46,7 @@
   &reftitle.returnvalues;
   <simpara>
    Returns a <type>float</type> corresponding to
-   <code><parameter>num</parameter><superscript>$exponent</superscript></code>.
+   <code>$num<superscript>$exponent</superscript></code>.
   </simpara>
  </refsect1>
 

From 040a14da4d974ef1269fb29a4273ca5a8b4006a9 Mon Sep 17 00:00:00 2001
From: Gina Peter Banyard <girgias@php.net>
Date: Tue, 12 Nov 2024 14:11:38 +0000
Subject: [PATCH 3/4] Fix sentence

---
 reference/math/functions/fpow.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/reference/math/functions/fpow.xml b/reference/math/functions/fpow.xml
index 8341d120e9d2..012aaa22184f 100644
--- a/reference/math/functions/fpow.xml
+++ b/reference/math/functions/fpow.xml
@@ -27,7 +27,7 @@
     <term><parameter>num</parameter></term>
     <listitem>
      <simpara>
-      The base to number.
+      The base to use.
      </simpara>
     </listitem>
    </varlistentry>

From 2da7bf05d90043672e2847c399b45d11da5a0505 Mon Sep 17 00:00:00 2001
From: Gina Peter Banyard <girgias@php.net>
Date: Tue, 12 Nov 2024 14:16:34 +0000
Subject: [PATCH 4/4] Address review comments

---
 reference/math/functions/fdiv.xml |  4 ++++
 reference/math/functions/fpow.xml | 10 ++++++----
 reference/math/functions/pow.xml  |  4 ++++
 3 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/reference/math/functions/fdiv.xml b/reference/math/functions/fdiv.xml
index f05efef8f086..95457f616bc7 100644
--- a/reference/math/functions/fdiv.xml
+++ b/reference/math/functions/fdiv.xml
@@ -76,6 +76,10 @@ var_dump(fdiv(0.0, 0.0)); // float(NAN)
   &reftitle.seealso;
   <para>
    <simplelist>
+    <member>
+     Division operator
+     <link linkend="language.operators.arithmetic"><literal>/</literal></link>
+    </member>
     <member><function>intdiv</function> - Integer division</member>
     <member><function>fmod</function></member>
     <member><function>fpow</function></member>
diff --git a/reference/math/functions/fpow.xml b/reference/math/functions/fpow.xml
index 012aaa22184f..dc8a2d264fb1 100644
--- a/reference/math/functions/fpow.xml
+++ b/reference/math/functions/fpow.xml
@@ -57,6 +57,7 @@
    <programlisting role="php">
 <![CDATA[
 <?php
+var_dump(fpow(10, 2));
 var_dump(fpow(0, -3));
 var_dump(fpow(-1, 5.5));
 ?>
@@ -65,6 +66,7 @@ var_dump(fpow(-1, 5.5));
    &example.outputs;
    <screen>
 <![CDATA[
+float(100)
 float(INF)
 float(NAN)
 ]]>
@@ -75,13 +77,13 @@ float(NAN)
  <refsect1 role="seealso">
   &reftitle.seealso;
   <simplelist>
-   <member><link linkend="language.operators.arithmetic"><literal>/</literal></link> - Floating-point division</member>
+   <member>
+    Exponentiation operator
+    <link linkend="language.operators.arithmetic"><literal>**</literal></link>
+   </member>
    <member><function>pow</function></member>
    <member><function>fdiv</function></member>
    <member><function>fmod</function></member>
-   <!-- TODO ** operator link?
-   <member><link linkend="some.id.chunk.to.link">something appendix</link></member>
-   -->
   </simplelist>
  </refsect1>
 
diff --git a/reference/math/functions/pow.xml b/reference/math/functions/pow.xml
index 7788e11c247f..fd6f17147dd4 100644
--- a/reference/math/functions/pow.xml
+++ b/reference/math/functions/pow.xml
@@ -95,6 +95,10 @@ echo pow(-1, 5.5); // NAN
   &reftitle.seealso;
   <para>
    <simplelist>
+    <member>
+     Exponentiation operator
+     <link linkend="language.operators.arithmetic"><literal>**</literal></link>
+    </member>
     <member><function>fpow</function></member>
     <member><function>exp</function></member>
     <member><function>sqrt</function></member>