Skip to content

Added PHP 8 into versions.xml for dom based on stubs. #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2021
Merged

Added PHP 8 into versions.xml for dom based on stubs. #431

merged 1 commit into from
May 15, 2021

Conversation

mumumu
Copy link
Member

@mumumu mumumu commented Jan 31, 2021

Generated verions.xml based on the following stubs.

  • https://github.com/php/php-src/blob/PHP-8.0/ext/dom/php_dom.stub.php
  • Note
    • the following methods not implemented in PHP-8.0.
      • domdocument
        • domdocument::renamenode
      • domimplementation
        • domimplementation::source_get_domimplementations
        • domimplementation::source_get_domimplementation
        • domimplementation::listitem
      • domnamednodemap
        • domnamednodemap::removenameditem
        • domnamednodemap::removenameditemns
        • domnamednodemap::setnameditem
        • domnamednodemap::setnameditemns
      • domnode
        • domnode::getfeature
        • domnode::comparedocumentposition
        • domnode::getuserdata
        • domnode::isequalnode
        • domnode::setuserdata
        • domtext::replacewholetext
    • not exist in stub file, but exists in manual, and can be used in PHP 8.0
      • domimplementation::__construct

@mumumu
Copy link
Member Author

mumumu commented May 15, 2021 •
edited
Loading

Note: We should follow new API DOMParentNode, DOMChildNode and related changes.
Anyway, I will merge this PR because unmerged versions.xml is harmful to manual readers.

@mumumu mumumu merged commit 86ff4f0 into php:master May 15, 2021
@mumumu mumumu deleted the add-php8-version-for-dom branch May 15, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mumumu