Skip to content

[PHP8.4] Change PHP_DEBUG and PHP_ZTS to bool の翻訳 #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2024
Merged

[PHP8.4] Change PHP_DEBUG and PHP_ZTS to bool の翻訳 #182

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ccf25
[PHP8.4] Change PHP_DEBUG and PHP_ZTS to bool の翻訳
asumikam Nov 22, 2024
523d94d
`EN-Revision` の更新
KentarouTakeda Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions appendices/reserved.constants.core.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@
<varlistentry xml:id="constant.php-zts">
<term>
<constant>PHP_ZTS</constant>
(<type>int</type>)
(<type>bool</type>)
<constant>ZEND_THREAD_SAFE</constant> &Alias;
Copy link
Collaborator

@KentarouTakeda KentarouTakeda Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

これナイスです！文章の構造のため、原文と順序が逆になるんですね。レビューで初めて知りました…
私が訳してたら、半端に慣れてるおかげでむしろ間違えていたかもしれない😇

Copy link
Contributor Author

@asumikam asumikam Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私もプレビューで見て、「なんか・・・これ変だな・・・」ってなって気づきました！ww
ありがとうございます！！！

</term>
<listitem>
<simpara>
Expand All @@ -118,8 +119,9 @@
</varlistentry>
<varlistentry xml:id="constant.php-debug">
<term>
<constant>PHP_DEBUG</constant>
(<type>int</type>)
<constant>PHP_DEBUG</constant>
(<type>bool</type>)
<constant>ZEND_DEBUG_BUILD</constant> &Alias;
</term>
<listitem>
<simpara>
Expand Down