Skip to content

Commit 1bfa3db

Browse files
fix(extgen): use fast ZPP (#2088)
Fast ZPP is being more and more widely used in php-src with PR such as php/php-src#20441 or php/php-src#20644, let's use it here as well.
1 parent 0b470ab commit 1bfa3db

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

internal/extgen/paramparser.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,7 @@ func (pp *ParameterParser) getDefaultValue(param phpParameter, fallback string)
8888

8989
func (pp *ParameterParser) generateParamParsing(params []phpParameter, requiredCount int) string {
9090
if len(params) == 0 {
91-
return ` if (zend_parse_parameters_none() == FAILURE) {
92-
RETURN_THROWS();
93-
}`
91+
return ` ZEND_PARSE_PARAMETERS_NONE();`
9492
}
9593

9694
var builder strings.Builder

internal/extgen/paramparser_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -223,9 +223,7 @@ func TestParameterParser_GenerateParamParsing(t *testing.T) {
223223
name: "no parameters",
224224
params: []phpParameter{},
225225
requiredCount: 0,
226-
expected: ` if (zend_parse_parameters_none() == FAILURE) {
227-
RETURN_THROWS();
228-
}`,
226+
expected: ` ZEND_PARSE_PARAMETERS_NONE();`,
229227
},
230228
{
231229
name: "single required string parameter",

0 commit comments

Comments
 (0)