Some instances are harmless and can be ignored

NattyNarwhal · NattyNarwhal · commit 3397bd4cee4f · 2021-03-10T12:47:35.000-05:00
diff --git a/ibm_db2.c b/ibm_db2.c
@@ -1081,8 +1081,12 @@ static void _php_db2_check_sql_errors( SQLHANDLE handle, SQLSMALLINT hType, int
             default:
                 break;
         }
-    } else {
-        php_error_docref(NULL, E_WARNING, "SQLGetDiagRec failed (is the driver working?)");
+    /*
+     * Some conversion errors in tests will return -1 and poke this function,
+     * but there won't be any SQL errors to get, so don't cause a false alarm
+     */
+    } else if (sqlrc != SQL_NO_DATA_FOUND) {
+        php_error_docref(NULL, E_WARNING, "SQLGetDiagRec returned %d (is the driver working?)", sqlrc);
     }
 }
 /* }}} */

Original file line number	Diff line number	Diff line change
`@@ -1081,8 +1081,12 @@ static void _php_db2_check_sql_errors( SQLHANDLE handle, SQLSMALLINT hType, int`
`1081`	`1081`	`default:`
`1082`	`1082`	`break;`
`1083`	`1083`	`}`
`1084`		`- } else {`
`1085`		`- php_error_docref(NULL, E_WARNING, "SQLGetDiagRec failed (is the driver working?)");`
	`1084`	`+ /*`
	`1085`	`+ * Some conversion errors in tests will return -1 and poke this function,`
	`1086`	`+ * but there won't be any SQL errors to get, so don't cause a false alarm`
	`1087`	`+ */`
	`1088`	`+ } else if (sqlrc != SQL_NO_DATA_FOUND) {`
	`1089`	`+ php_error_docref(NULL, E_WARNING, "SQLGetDiagRec returned %d (is the driver working?)", sqlrc);`
`1086`	`1090`	`}`
`1087`	`1091`	`}`
`1088`	`1092`	`/* }}} */`