Modify the string only if it's been successfully allocated

NattyNarwhal · NattyNarwhal · commit f85e3ffc4463 · 2021-01-28T10:28:43.000-05:00
diff --git a/ibm_db2.c b/ibm_db2.c
@@ -6016,11 +6016,11 @@ PHP_FUNCTION(db2_result)
                     RETURN_NULL();
                 }
                 out_char_ptr = (SQLPOINTER)ecalloc(1, in_length+2);
-                out_char_ptr[in_length+1] = '\0';
                 if ( out_char_ptr == NULL ) {
                     php_error_docref(NULL, E_WARNING, "Cannot Allocate Memory");
                     RETURN_FALSE;
                 }
+                out_char_ptr[in_length+1] = '\0';
                 rc = _php_db2_get_data(stmt_res, col_num+1, lob_bind_type, out_char_ptr+1, in_length, &out_length);
                 out_char_ptr[0] = i5oshack;
                 if ( rc == SQL_ERROR ) {

Original file line number	Diff line number	Diff line change
`@@ -6016,11 +6016,11 @@ PHP_FUNCTION(db2_result)`
`6016`	`6016`	`RETURN_NULL();`
`6017`	`6017`	`}`
`6018`	`6018`	`out_char_ptr = (SQLPOINTER)ecalloc(1, in_length+2);`
`6019`		`- out_char_ptr[in_length+1] = '\0';`
`6020`	`6019`	`if ( out_char_ptr == NULL ) {`
`6021`	`6020`	`php_error_docref(NULL, E_WARNING, "Cannot Allocate Memory");`
`6022`	`6021`	`RETURN_FALSE;`
`6023`	`6022`	`}`
	`6023`	`+ out_char_ptr[in_length+1] = '\0';`
`6024`	`6024`	`rc = _php_db2_get_data(stmt_res, col_num+1, lob_bind_type, out_char_ptr+1, in_length, &out_length);`
`6025`	`6025`	`out_char_ptr[0] = i5oshack;`
`6026`	`6026`	`if ( rc == SQL_ERROR ) {`