Failure to load with PHP 8.5.0beta2

[rainerjung]

Loading the extension build against PHP 8.5.0beta2 with this version results in the error:

.../sbin/php-fpm: symbol lookup error: /.../8.5.0beta2-1/lib/php/extensions/no-debug-non-zts-20240925/pdo_oci.so: undefined symbol: REGISTER_PDO_CLASS_CONST_LONG

It worked for 8.5.0alpha2 but it is broken now. It is probably due to this change in pdo_php.h in the master branch:

php/php-src@6f32e1c

Best regards,

Rainer

[cmb69]

Maybe try to replace REGISTER_PDO_CLASS_CONST_LONG with REGISTER_PDO_CLASS_CONST_LONG_DEPRECATED_85.

[rainerjung]

Checked against PHP 8.5.0RC1. That change makes it compile and run, but 4 unit tests fail:

PDO_OCI: Attribute: Setting session action [ext/pdo_oci/tests/pdo_oci_attr_action.phpt]
PDO_OCI: Attribute: Setting session client identifier [ext/pdo_oci/tests/pdo_oci_attr_client_identifier.phpt]
PDO_OCI: Attribute: Setting session client info [ext/pdo_oci/tests/pdo_oci_attr_client_info.phpt]
PDO_OCI: Attribute: Setting session module [ext/pdo_oci/tests/pdo_oci_attr_module.phpt]

Example:

$ cat ext/pdo_oci/tests/pdo_oci_attr_action.log

---- EXPECTED OUTPUT
ACTION NOT SET: NULL
bool(true)
ACTION SET: string(11) "some action"
bool(true)
ACTION RESET: string(15) "something else!"
bool(true)
ACTION NULLED: NULL
Done
---- ACTUAL OUTPUT
ACTION NOT SET: NULL

Deprecated: Constant PDO::OCI_ATTR_ACTION is deprecated since 8.5 in path/to/ext/pdo_oci/tests/pdo_oci_attr_action.php on line 14
bool(true)
ACTION SET: string(11) "some action"

Deprecated: Constant PDO::OCI_ATTR_ACTION is deprecated since 8.5 in /path/to/ext/pdo_/esb-vmhost/vmshared/autobuild/workdirs/20250928_091930/bld/php85oci/tests/pdo_oci_attr_action.php on line 21
bool(true)
ACTION RESET: string(15) "something else!"

Deprecated: Constant PDO::OCI_ATTR_ACTION is deprecated since 8.5 in /path/to/ext/pdo_oci/tests/pdo_oci_attr_action.php on line 28
bool(true)
ACTION NULLED: NULL
Done
---- FAILED

[mvorisek]

The constants should be declared in a new PDO driver specific class - https://wiki.php.net/rfc/pdo_driver_specific_subclasses.