Bug #72740 No need of strlen() for empty check

Author: scara

src/php5/solr_functions_params.c

@@ -713,7 +713,7 @@ PHP_SOLR_API void solr_arg_list_param_value_fetch(solr_param_t *solr_param, solr
 	{
 		solr_string_append_solr_string(&tmp_buffer, &(current_ptr->contents.arg_list.value));
 
-		if (current_ptr->contents.arg_list.delimiter_override && strlen(current_ptr->contents.arg_list.delimiter_override) > 0) {
+		if (current_ptr->contents.arg_list.delimiter_override && *current_ptr->contents.arg_list.delimiter_override) {
 		    solr_string_appendc(&tmp_buffer, *current_ptr->contents.arg_list.delimiter_override);
 		} else {
 		    solr_string_appendc(&tmp_buffer, separator);
@@ -730,7 +730,7 @@ PHP_SOLR_API void solr_arg_list_param_value_fetch(solr_param_t *solr_param, solr
 
 	solr_string_append_solr_string(&tmp_buffer, &(current_ptr->contents.arg_list.value));
 
-	if (current_ptr->contents.arg_list.delimiter_override && strlen(current_ptr->contents.arg_list.delimiter_override) > 0) {
+	if (current_ptr->contents.arg_list.delimiter_override && *current_ptr->contents.arg_list.delimiter_override) {
 	    solr_string_appendc(&tmp_buffer, *current_ptr->contents.arg_list.delimiter_override);
 	} else {
 	    solr_string_appendc(&tmp_buffer, separator);

src/php7/solr_functions_params.c

@@ -700,7 +700,7 @@ PHP_SOLR_API void solr_arg_list_param_value_fetch(solr_param_t *solr_param, solr
 	{
 		solr_string_append_solr_string(&tmp_buffer, &(current_ptr->contents.arg_list.value));
 
-		if (current_ptr->contents.arg_list.delimiter_override && strlen(current_ptr->contents.arg_list.delimiter_override) > 0) {
+		if (current_ptr->contents.arg_list.delimiter_override && *current_ptr->contents.arg_list.delimiter_override) {
 		    solr_string_appendc(&tmp_buffer, *current_ptr->contents.arg_list.delimiter_override);
 		} else {
 		    solr_string_appendc(&tmp_buffer, separator);
@@ -717,7 +717,7 @@ PHP_SOLR_API void solr_arg_list_param_value_fetch(solr_param_t *solr_param, solr
 
 	solr_string_append_solr_string(&tmp_buffer, &(current_ptr->contents.arg_list.value));
 
-	if (current_ptr->contents.arg_list.delimiter_override && strlen(current_ptr->contents.arg_list.delimiter_override) > 0) {
+	if (current_ptr->contents.arg_list.delimiter_override && *current_ptr->contents.arg_list.delimiter_override) {
 	    solr_string_appendc(&tmp_buffer, *current_ptr->contents.arg_list.delimiter_override);
 	} else {
 	    solr_string_appendc(&tmp_buffer, separator);