From cad547a3408486d6cc0383946084269193903ae5 Mon Sep 17 00:00:00 2001 From: Jan-E Date: Sun, 12 Jul 2020 12:23:09 +0200 Subject: [PATCH] zend_hash_sort never fails since PHP 5.5.0 See https://github.com/php/php-src/pull/3936#issuecomment-652122802 --- src/php7/php_solr_document.c | 5 +---- src/php7/php_solr_input_document.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/php7/php_solr_document.c b/src/php7/php_solr_document.c index 158130ba..cec42cf0 100644 --- a/src/php7/php_solr_document.c +++ b/src/php7/php_solr_document.c @@ -1130,10 +1130,7 @@ PHP_METHOD(SolrDocument, sort) RETURN_FALSE; } - if (zend_hash_sort_ex(doc_entry->fields, zend_qsort, comparison_function, renumber TSRMLS_CC) == FAILURE) { - - RETURN_FALSE; - } + zend_hash_sort_ex(doc_entry->fields, zend_qsort, comparison_function, renumber TSRMLS_CC); RETURN_TRUE; } diff --git a/src/php7/php_solr_input_document.c b/src/php7/php_solr_input_document.c index 1722a839..76e38527 100644 --- a/src/php7/php_solr_input_document.c +++ b/src/php7/php_solr_input_document.c @@ -655,10 +655,7 @@ PHP_METHOD(SolrInputDocument, sort) RETURN_FALSE; } - if (zend_hash_sort_ex(doc_entry->fields, zend_qsort, comparison_function, renumber TSRMLS_CC) == FAILURE) { - - RETURN_FALSE; - } + zend_hash_sort_ex(doc_entry->fields, zend_qsort, comparison_function, renumber TSRMLS_CC); RETURN_TRUE; }