-
Notifications
You must be signed in to change notification settings - Fork 45
Open
Description
php-sdk-binary-tools/lib/php/libsdk/SDK/Build/Dependency/Fetcher.php
Lines 59 to 65 in 6d41b82
| } catch (Exception $e) { | |
| if ($retries > 0) { | |
| sleep(1); | |
| $retries--; | |
| goto retry; | |
| } | |
| } |
Probably should rethrow this exception when the number of retries is exceeded?
Currently it'll just return an empty string on repeated failures
When the SDK deps download is used in a build script, it's not outwardly obvious that there were problems downloading the deps, since the command doesn't fail
Metadata
Metadata
Assignees
Labels
No labels