Review

Girgias · Girgias · commit 000fe4413d3f · 2025-09-13T17:49:56.000+01:00
diff --git a/ext/standard/string.c b/ext/standard/string.c
@@ -2661,7 +2661,7 @@ PHP_FUNCTION(ord)
 				"Providing an empty string is deprecated");
 		} else {
 			php_error_docref(NULL, E_DEPRECATED,
-				"Providing a string which is not one byte long is deprecated, use ord($str[0]) instead");
+				"Providing a string that is not one byte long is deprecated. Use ord($str[0]) instead");
 		}
 	}
 	RETURN_LONG((unsigned char) ZSTR_VAL(str)[0]);
diff --git a/ext/standard/tests/strings/ord_not_1_byte.phpt b/ext/standard/tests/strings/ord_not_1_byte.phpt
@@ -11,5 +11,5 @@ var_dump(ord("Hello"));
 Deprecated: ord(): Providing an empty string is deprecated in %s on line 3
 int(0)
 
-Deprecated: ord(): Providing a string which is not one byte long is deprecated, use ord($str[0]) instead in %s on line 4
+Deprecated: ord(): Providing a string that is not one byte long is deprecated. Use ord($str[0]) instead in %s on line 4
 int(72)

Original file line number	Diff line number	Diff line change
`@@ -2661,7 +2661,7 @@ PHP_FUNCTION(ord)`
`2661`	`2661`	`"Providing an empty string is deprecated");`
`2662`	`2662`	`} else {`
`2663`	`2663`	`php_error_docref(NULL, E_DEPRECATED,`
`2664`		`- "Providing a string which is not one byte long is deprecated, use ord($str[0]) instead");`
	`2664`	`+ "Providing a string that is not one byte long is deprecated. Use ord($str[0]) instead");`
`2665`	`2665`	`}`
`2666`	`2666`	`}`
`2667`	`2667`	`RETURN_LONG((unsigned char) ZSTR_VAL(str)[0]);`