Zend: Warn when destructuring non-array values

Girgias · Girgias · commit 037487d22e7a · 2025-08-10T01:03:22.000+01:00
RFC: https://wiki.php.net/rfc/warnings-php-8-5#destructuring_non-array_values
diff --git a/Zend/tests/foreach/foreach_list_002.phpt b/Zend/tests/foreach/foreach_list_002.phpt
@@ -17,6 +17,8 @@ foreach($array as list(, $a)) {
 --EXPECT--
 int(1)
 int(3)
-string(1) "b"
+string(1)
+
+Warning: Cannot use string as array in %s on line %d
 NULL
 NULL
diff --git a/Zend/tests/list/bug39304.phpt b/Zend/tests/list/bug39304.phpt
@@ -8,5 +8,9 @@ Bug #39304 (Segmentation fault with list unpacking of string offset)
 ?>
 --EXPECTF--
 Warning: Uninitialized string offset 0 in %s on line %d
+
+Warning: Cannot use string as array in %s on line %d
+
+Warning: Cannot use string as array in %s on line %d
 NULL
 NULL
diff --git a/Zend/tests/list/destruct_bool.phpt b/Zend/tests/list/destruct_bool.phpt
@@ -0,0 +1,18 @@
+--TEST--
+Destructuring with list() a value of type bool
+--FILE--
+<?php
+
+$v = true;
+
+list($a, $b) = $v;
+
+var_dump($a, $b);
+
+?>
+--EXPECTF--
+Warning: Cannot use bool as array in %s on line %d
+
+Warning: Cannot use bool as array in %s on line %d
+NULL
+NULL
diff --git a/Zend/tests/list/destruct_float.phpt b/Zend/tests/list/destruct_float.phpt
@@ -0,0 +1,18 @@
+--TEST--
+Destructuring with list() a value of type float
+--FILE--
+<?php
+
+$v = 25.64;
+
+list($a, $b) = $v;
+
+var_dump($a, $b);
+
+?>
+--EXPECTF--
+Warning: Cannot use float as array in %s on line %d
+
+Warning: Cannot use float as array in %s on line %d
+NULL
+NULL
diff --git a/Zend/tests/list/destruct_int.phpt b/Zend/tests/list/destruct_int.phpt
@@ -0,0 +1,18 @@
+--TEST--
+Destructuring with list() a value of type int
+--FILE--
+<?php
+
+$v = 5;
+
+list($a, $b) = $v;
+
+var_dump($a, $b);
+
+?>
+--EXPECTF--
+Warning: Cannot use int as array in %s on line %d
+
+Warning: Cannot use int as array in %s on line %d
+NULL
+NULL
diff --git a/Zend/tests/list/destruct_null.phpt b/Zend/tests/list/destruct_null.phpt
@@ -0,0 +1,12 @@
+--TEST--
+Destructuring with list() a value of type null
+--FILE--
+<?php
+
+list($a) = null;
+
+var_dump($a);
+
+?>
+--EXPECT--
+NULL
diff --git a/Zend/tests/list/destruct_object_not_ArrayAccess.phpt b/Zend/tests/list/destruct_object_not_ArrayAccess.phpt
@@ -0,0 +1,17 @@
+--TEST--
+Destructuring with list() a value of type object (that does not implement ArrayAccess)
+--FILE--
+<?php
+
+$v = new stdClass();
+
+list($a, $b) = $v;
+
+var_dump($a, $b);
+
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Cannot use object of type stdClass as array in %s:%d
+Stack trace:
+#0 {main}
+  thrown in %s on line %d
diff --git a/Zend/tests/list/destruct_resource.phpt b/Zend/tests/list/destruct_resource.phpt
@@ -0,0 +1,18 @@
+--TEST--
+Destructuring with list() a value of type resource
+--FILE--
+<?php
+
+$v = STDERR;
+
+list($a, $b) = $v;
+
+var_dump($a, $b);
+
+?>
+--EXPECTF--
+Warning: Cannot use resource as array in %s on line %d
+
+Warning: Cannot use resource as array in %s on line %d
+NULL
+NULL
diff --git a/Zend/tests/list/destruct_string.phpt b/Zend/tests/list/destruct_string.phpt
@@ -0,0 +1,21 @@
+--TEST--
+Destructuring with list() a value of type string
+--FILE--
+<?php
+
+$v = 'hi';
+
+list($a, $b, $c) = $v;
+
+var_dump($a, $b, $c);
+
+?>
+--EXPECTF--
+Warning: Cannot use string as array in %s on line %d
+
+Warning: Cannot use string as array in %s on line %d
+
+Warning: Cannot use string as array in %s on line %d
+NULL
+NULL
+NULL
diff --git a/Zend/tests/list/list_003.phpt b/Zend/tests/list/list_003.phpt
diff --git a/Zend/tests/list/list_005.phpt b/Zend/tests/list/list_005.phpt
diff --git a/Zend/zend_execute.c b/Zend/zend_execute.c
@@ -3005,7 +3005,7 @@ static zend_never_inline void ZEND_FASTCALL zend_fetch_dimension_address_UNSET(z
 	zend_fetch_dimension_address(result, container_ptr, dim, dim_type, BP_VAR_UNSET EXECUTE_DATA_CC);
 }
 
-static zend_always_inline void zend_fetch_dimension_address_read(zval *result, zval *container, zval *dim, int dim_type, int type, bool is_list, int slow EXECUTE_DATA_DC)
+static zend_always_inline void zend_fetch_dimension_address_read(zval *result, zval *container, zval *dim, int dim_type, int type, bool is_list, bool slow EXECUTE_DATA_DC)
 {
 	zval *retval;
 
@@ -3143,6 +3143,9 @@ static zend_always_inline void zend_fetch_dimension_address_read(zval *result, z
 		if (ZEND_CONST_COND(dim_type == IS_CV, 1) && UNEXPECTED(Z_TYPE_P(dim) == IS_UNDEF)) {
 			ZVAL_UNDEFINED_OP2();
 		}
+		if (is_list && Z_TYPE_P(container) > IS_NULL) {
+			zend_error(E_WARNING, "Cannot use %s as array", zend_zval_type_name(container));
+		}
 		if (!is_list && type != BP_VAR_IS) {
 			zend_error(E_WARNING, "Trying to access array offset on %s",
 				zend_zval_value_name(container));
diff --git a/ext/opcache/tests/jit/fetch_list_r_001.phpt b/ext/opcache/tests/jit/fetch_list_r_001.phpt
@@ -13,5 +13,6 @@ function test() {
 }
 test();
 ?>
---EXPECT--
+--EXPECTF--
+Warning: Cannot use string as array in %s on line %d
 NULL
diff --git a/ext/opcache/tests/opt/block_pass_003.phpt b/ext/opcache/tests/opt/block_pass_003.phpt
@@ -1,5 +1,5 @@
 --TEST--
-Block Pass 003: Inorrect constant substitution in FETCH_LIST_R
+Block Pass 003: Incorrect constant substitution in FETCH_LIST_R
 --INI--
 opcache.enable=1
 opcache.enable_cli=1
@@ -16,5 +16,8 @@ function test() {
 test();
 ?>
 DONE
---EXPECT--
+--EXPECTF--
+Warning: Cannot use int as array in %s on line %d
+
+Warning: Cannot use int as array in %s on line %d
 DONE
diff --git a/tests/lang/engine_assignExecutionOrder_002.phpt b/tests/lang/engine_assignExecutionOrder_002.phpt
@@ -116,6 +116,10 @@ array(3) {
   int(3000)
 }
 L=100 M=200 N=300
+
+Warning: Cannot use int as array in %s on line %d
+
+Warning: Cannot use int as array in %s on line %d
 O= and P=
 10 20 40 50 60 70 80
 
