Skip to content

Commit 072c50f

Browse files
committed
Merge branch 'PHP-8.0'
* PHP-8.0: Update msan job to Ubuntu 20.04 Skip some tests under msan
2 parents 4ece535 + f547bdd commit 072c50f

10 files changed

+32
-19
lines changed

azure/msan_job.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
- job: ${{ parameters.configurationName }}
99
timeoutInMinutes: ${{ parameters.timeoutInMinutes }}
1010
pool:
11-
vmImage: 'ubuntu-18.04'
11+
vmImage: 'ubuntu-20.04'
1212
steps:
1313
- template: apt.yml
1414
- script: |

azure/test.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ steps:
1515
export TEST_PHP_JUNIT=junit.xml
1616
export REPORT_EXIT_STATUS=no
1717
export SKIP_IO_CAPTURE_TESTS=1
18-
export MSAN_SYMBOLIZER_PATH=/usr/lib/llvm-6.0/bin/llvm-symbolizer
1918
rm -rf junit.xml | true
2019
sapi/cli/php run-tests.php -P -q \
2120
-j$(/usr/bin/nproc) \

ext/standard/tests/general_functions/getservbyname_basic.phpt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ Michele Orselli ([email protected])
77
Simone Gentili ([email protected])
88
--SKIPIF--
99
<?php
10-
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
11-
if (!file_exists("/etc/services")) die("skip reason: missing /etc/services");
12-
}
10+
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
11+
if (!file_exists("/etc/services")) die("skip reason: missing /etc/services");
12+
}
13+
if (getenv('SKIP_MSAN')) die('skip msan missing interceptor for getservbyname()');
1314
?>
1415
--FILE--
1516
<?php

ext/standard/tests/general_functions/getservbyport_basic.phpt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ Michele Orselli ([email protected])
77
Simone Gentili ([email protected])
88
--SKIPIF--
99
<?php
10-
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
11-
if (!file_exists("/etc/services")) die("skip reason: missing /etc/services");
12-
}
10+
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
11+
if (!file_exists("/etc/services")) die("skip reason: missing /etc/services");
12+
}
13+
if (getenv('SKIP_MSAN')) die('skip msan missing interceptor for getservbyport()');
1314
?>
1415
--FILE--
1516
<?php

ext/standard/tests/general_functions/getservbyport_variation1.phpt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@ Michele Orselli ([email protected])
99
Simone Gentili ([email protected])
1010
--SKIPIF--
1111
<?php
12-
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
13-
if (!file_exists("/etc/services")) die("skip reason: missing /etc/services");
14-
}
12+
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
13+
if (!file_exists("/etc/services")) die("skip reason: missing /etc/services");
14+
}
15+
if (getenv('SKIP_MSAN')) die('skip msan missing interceptor for getservbyport()');
1516
?>
1617
--FILE--
1718
<?php

ext/standard/tests/network/getmxrr.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ if (getenv("SKIP_ONLINE_TESTS")) die("skip test requiring internet connection");
77
if (substr(PHP_OS, 0, 3) == 'WIN') {
88
die('skip: no Windows support');
99
}
10+
if (getenv('SKIP_MSAN')) die('skip msan missing interceptor for dn_expand()');
1011
?>
1112
--FILE--
1213
<?php

ext/standard/tests/network/getprotobyname_basic.phpt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@ getprotobyname function basic test
44
edgarsandi - <[email protected]>
55
--SKIPIF--
66
<?php
7-
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
8-
if (!file_exists("/etc/protocols")) die("skip reason: missing /etc/protocols");
9-
}
7+
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
8+
if (!file_exists("/etc/protocols")) die("skip reason: missing /etc/protocols");
9+
}
10+
if (getenv('SKIP_MSAN')) die('skip msan missing interceptor for getprotobyname()');
1011
?>
1112
--FILE--
1213
<?php
13-
var_dump(getprotobyname('tcp'));
14+
var_dump(getprotobyname('tcp'));
1415
?>
1516
--EXPECT--
1617
int(6)

ext/standard/tests/network/getprotobyname_error.phpt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
getprotobyname function errors test
33
--CREDITS--
44
edgarsandi - <[email protected]>
5+
--SKIPIF--
6+
<?php
7+
if (getenv('SKIP_MSAN')) die('skip msan missing interceptor for getprotobyname()');
8+
?>
59
--FILE--
610
<?php
711
// invalid protocol name

ext/standard/tests/network/getprotobynumber_basic.phpt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,14 @@ getprotobynumber function basic test
44
edgarsandi - <[email protected]>
55
--SKIPIF--
66
<?php
7-
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
8-
if (!file_exists("/etc/protocols")) die("skip reason: missing /etc/protocols");
9-
}
7+
if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){
8+
if (!file_exists("/etc/protocols")) die("skip reason: missing /etc/protocols");
9+
}
10+
if (getenv('SKIP_MSAN')) die('skip msan missing interceptor for getprotobynumber()');
1011
?>
1112
--FILE--
1213
<?php
13-
var_dump(getprotobynumber(6));
14+
var_dump(getprotobynumber(6));
1415
?>
1516
--EXPECT--
1617
string(3) "tcp"

ext/standard/tests/network/getprotobynumber_error.phpt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
getprotobynumber function errors test
33
--CREDITS--
44
edgarsandi - <[email protected]>
5+
--SKIPIF--
6+
<?php
7+
if (getenv('SKIP_MSAN')) die('skip msan missing interceptor for getprotobynumber()');
8+
?>
59
--FILE--
610
<?php
711
// invalid protocol number

0 commit comments

Comments
 (0)