Skip to content

Commit 090e3fb

Browse files
committed
Fix [-Wimplicit-fallthrough] warnings in Phar extension
1 parent 8e40c79 commit 090e3fb

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

ext/phar/phar_object.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1485,7 +1485,7 @@ static int phar_build(zend_object_iterator *iter, void *puser) /* {{{ */
14851485
goto phar_spl_fileinfo;
14861486
}
14871487
}
1488-
/* fall-through */
1488+
fallthrough;
14891489
default:
14901490
zend_throw_exception_ex(spl_ce_UnexpectedValueException, 0, "Iterator %s returned an invalid value (must return a string)", ZSTR_VAL(ce->name));
14911491
return ZEND_HASH_APPLY_STOP;

ext/phar/util.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1892,6 +1892,7 @@ int phar_create_signature(phar_archive_data *phar, php_stream *fp, char **signat
18921892
break;
18931893
default:
18941894
phar->sig_flags = PHAR_SIG_SHA1;
1895+
fallthrough;
18951896
case PHAR_SIG_SHA1: {
18961897
unsigned char digest[20];
18971898
PHP_SHA1_CTX context;

0 commit comments

Comments
 (0)