Change lang from ?string to string

Author: ndossche

ext/soap/soap.c

@@ -657,7 +657,7 @@ static void soap_fault_dtor_properties(zval *obj)
 	ZVAL_NULL(Z_FAULT_DETAIL_P(obj));
 	ZVAL_NULL(Z_FAULT_NAME_P(obj));
 	ZVAL_NULL(Z_FAULT_HEADERFAULT_P(obj));
-	ZVAL_NULL(Z_FAULT_LANG_P(obj));
+	ZVAL_EMPTY_STRING(Z_FAULT_LANG_P(obj));
 }
 
 /* {{{ SoapFault constructor */
@@ -1724,11 +1724,11 @@ PHP_METHOD(SoapServer, fault)
 	size_t code_len, string_len, actor_len = 0;
 	zval* details = NULL;
 	zend_string *name = NULL;
-	zend_string *lang = NULL;
+	zend_string *lang = ZSTR_EMPTY_ALLOC();
 	soapServicePtr service;
 	xmlCharEncodingHandlerPtr old_encoding;
 
-	if (zend_parse_parameters(ZEND_NUM_ARGS(), "ss|szSS!",
+	if (zend_parse_parameters(ZEND_NUM_ARGS(), "ss|szSS",
 	    &code, &code_len, &string, &string_len, &actor, &actor_len, &details,
 	    &name, &lang) == FAILURE) {
 		RETURN_THROWS();
@@ -3754,7 +3754,7 @@ static xmlDocPtr serialize_response_call(sdlFunctionPtr function, const char *fu
 
 				/* xml:lang attribute is required for <Reason> in SOAP 1.2 */
 				tmp = Z_FAULT_LANG_P(ret);
-				zend_string *lang = Z_ISNULL_P(tmp) ? ZSTR_EMPTY_ALLOC() : Z_STR_P(tmp);
+				zend_string *lang = Z_STR_P(tmp);
 				xmlNodeSetLang(node, BAD_CAST ZSTR_VAL(lang));
 			}
 			detail_name = SOAP_1_2_ENV_NS_PREFIX":Detail";

ext/soap/soap.stub.php

@@ -477,9 +477,9 @@ class SoapFault extends Exception
         public mixed $detail = null;
         public ?string $_name = null;
         public mixed $headerfault = null;
-        public ?string $lang = null;
+        public string $lang = "";
 
-        public function __construct(array|string|null $code, string $string, ?string $actor = null, mixed $details = null, ?string $name = null, mixed $headerFault = null, ?string $lang = null) {}
+        public function __construct(array|string|null $code, string $string, ?string $actor = null, mixed $details = null, ?string $name = null, mixed $headerFault = null, string $lang = "") {}
 
         public function __toString(): string {}
     }
@@ -503,7 +503,7 @@ class SoapServer
         public function __construct(?string $wsdl, array $options = []) {}
 
         /** @tentative-return-type */
-        public function fault(string $code, string $string, string $actor = "", mixed $details = null, string $name = "", ?string $lang = null): void {}
+        public function fault(string $code, string $string, string $actor = "", mixed $details = null, string $name = "", string $lang = ""): void {}
 
         /** @tentative-return-type */
         public function addSoapHeader(SoapHeader $header): void {}