gen_stub: add and use FileInfo::getLegacyVersion()

Separate out the creation of a legacy version of a FileInfo object, which has
information for old versions of PHP discarded, from its subsequent use in
`processStubFile()`.

In the process, make `FileInfo::$legacyArginfoGeneration` private, and inline
the single use of `FileInfo::getAllClassInfos()`, removing that method.

Author: DanielEScherzer

build/gen_stub.php

@@ -133,19 +133,7 @@ function processStubFile(string $stubFile, Context $context, bool $includeOnly =
         }
 
         if ($fileInfo->shouldGenerateLegacyArginfo()) {
-            $legacyFileInfo = clone $fileInfo;
-            $legacyFileInfo->legacyArginfoGeneration = true;
-            $phpVersionIdMinimumCompatibility = $legacyFileInfo->getMinimumPhpVersionIdCompatibility();
-
-            foreach ($legacyFileInfo->getAllFuncInfos() as $funcInfo) {
-                $funcInfo->discardInfoForOldPhpVersions($phpVersionIdMinimumCompatibility);
-            }
-            foreach ($legacyFileInfo->getAllClassInfos() as $classInfo) {
-                $classInfo->discardInfoForOldPhpVersions($phpVersionIdMinimumCompatibility);
-            }
-            foreach ($legacyFileInfo->getAllConstInfos() as $constInfo) {
-                $constInfo->discardInfoForOldPhpVersions($phpVersionIdMinimumCompatibility);
-            }
+            $legacyFileInfo = $fileInfo->getLegacyVersion();
 
             $arginfoCode = generateArgInfoCode(
                 basename($stubFilenameWithoutExtension),
@@ -4172,7 +4160,7 @@ class FileInfo {
     public string $declarationPrefix = "";
     public bool $generateClassEntries = false;
     public bool $isUndocumentable = false;
-    public bool $legacyArginfoGeneration = false;
+    private bool $legacyArginfoGeneration = false;
     private ?int $minimumPhpVersionIdCompatibility = null;
 
     /** @param array<int, DocCommentTag> $fileTags */
@@ -4232,15 +4220,6 @@ public function getAllConstInfos(): array {
         return $result;
     }
 
-    /**
-     * @return iterable<ClassInfo>
-     */
-    public function getAllClassInfos(): iterable {
-        foreach ($this->classInfos as $classInfo) {
-            yield $classInfo;
-        }
-    }
-
     public function __clone()
     {
         foreach ($this->constInfos as $key => $constInfo) {
@@ -4272,6 +4251,23 @@ public function shouldGenerateLegacyArginfo(): bool {
         return $this->minimumPhpVersionIdCompatibility !== null && $this->minimumPhpVersionIdCompatibility < PHP_80_VERSION_ID;
     }
 
+    public function getLegacyVersion(): FileInfo {
+        $legacyFileInfo = clone $this;
+        $legacyFileInfo->legacyArginfoGeneration = true;
+        $phpVersionIdMinimumCompatibility = $legacyFileInfo->getMinimumPhpVersionIdCompatibility();
+
+        foreach ($legacyFileInfo->getAllFuncInfos() as $funcInfo) {
+            $funcInfo->discardInfoForOldPhpVersions($phpVersionIdMinimumCompatibility);
+        }
+        foreach ($legacyFileInfo->classInfos as $classInfo) {
+            $classInfo->discardInfoForOldPhpVersions($phpVersionIdMinimumCompatibility);
+        }
+        foreach ($legacyFileInfo->getAllConstInfos() as $constInfo) {
+            $constInfo->discardInfoForOldPhpVersions($phpVersionIdMinimumCompatibility);
+        }
+        return $legacyFileInfo;
+    }
+
     public function handleStatements(array $stmts, PrettyPrinterAbstract $prettyPrinter): void {
         $conds = [];
         foreach ($stmts as $stmt) {