Refactor mbfl_ident.c, mbfl_encoding.c, mbfl_memory_device.c, mbfl_string.c

- Make everything less gratuitously verbose
- Don't litter the code with lots of unneeded NULL checks (for things which
  will never be NULL)
- Don't return success/failure code from functions which can never fail
- For encoding structs, don't use pointers to pointers to pointers for the
  list of alias strings. Pointers to pointers (2 levels of indirection)
  is what actually makes sense. This gets rid of some extraneous
  dereference operations.

Author: alexdowad

ext/mbstring/libmbfl/filters/mbfilter_armscii8.c

@@ -38,7 +38,7 @@ const mbfl_encoding mbfl_encoding_armscii8 = {
 	mbfl_no_encoding_armscii8,
 	"ArmSCII-8",
 	"ArmSCII-8",
-	(const char *(*)[])&mbfl_encoding_armscii8_aliases,
+	mbfl_encoding_armscii8_aliases,
 	NULL,
 	MBFL_ENCTYPE_SBCS,
 	&vtbl_armscii8_wchar,

ext/mbstring/libmbfl/filters/mbfilter_ascii.c

@@ -39,7 +39,7 @@ const mbfl_encoding mbfl_encoding_ascii = {
 	mbfl_no_encoding_ascii,
 	"ASCII",
 	"US-ASCII", /* preferred MIME name */
-	(const char *(*)[])&mbfl_encoding_ascii_aliases,
+	mbfl_encoding_ascii_aliases,
 	NULL,
 	MBFL_ENCTYPE_SBCS,
 	&vtbl_ascii_wchar,

ext/mbstring/libmbfl/filters/mbfilter_big5.c

@@ -59,7 +59,7 @@ const mbfl_encoding mbfl_encoding_big5 = {
 	mbfl_no_encoding_big5,
 	"BIG-5",
 	"BIG5",
-	(const char *(*)[])&mbfl_encoding_big5_aliases,
+	mbfl_encoding_big5_aliases,
 	mblen_table_big5,
 	MBFL_ENCTYPE_MBCS | MBFL_ENCTYPE_GL_UNSAFE,
 	&vtbl_big5_wchar,

ext/mbstring/libmbfl/filters/mbfilter_cp1251.c

@@ -39,7 +39,7 @@ const mbfl_encoding mbfl_encoding_cp1251 = {
 	mbfl_no_encoding_cp1251,
 	"Windows-1251",
 	"Windows-1251",
-	(const char *(*)[])&mbfl_encoding_cp1251_aliases,
+	mbfl_encoding_cp1251_aliases,
 	NULL,
 	MBFL_ENCTYPE_SBCS,
 	&vtbl_cp1251_wchar,

ext/mbstring/libmbfl/filters/mbfilter_cp1252.c

@@ -39,7 +39,7 @@ const mbfl_encoding mbfl_encoding_cp1252 = {
 	mbfl_no_encoding_cp1252,
 	"Windows-1252",
 	"Windows-1252",
-	(const char *(*)[])&mbfl_encoding_cp1252_aliases,
+	mbfl_encoding_cp1252_aliases,
 	NULL,
 	MBFL_ENCTYPE_SBCS,
 	&vtbl_cp1252_wchar,

ext/mbstring/libmbfl/filters/mbfilter_cp1254.c

@@ -39,7 +39,7 @@ const mbfl_encoding mbfl_encoding_cp1254 = {
 	mbfl_no_encoding_cp1254,
 	"Windows-1254",
 	"Windows-1254",
-	(const char *(*)[])&mbfl_encoding_cp1254_aliases,
+	mbfl_encoding_cp1254_aliases,
 	NULL,
 	MBFL_ENCTYPE_SBCS,
 	&vtbl_cp1254_wchar,

ext/mbstring/libmbfl/filters/mbfilter_cp5022x.c

@@ -59,7 +59,7 @@ const mbfl_encoding mbfl_encoding_cp50220 = {
 	mbfl_no_encoding_cp50220,
 	"CP50220",
 	"ISO-2022-JP",
-	(const char *(*)[])NULL,
+	NULL,
 	NULL,
 	MBFL_ENCTYPE_MBCS | MBFL_ENCTYPE_GL_UNSAFE,
 	&vtbl_cp50220_wchar,
@@ -70,7 +70,7 @@ const mbfl_encoding mbfl_encoding_cp50220raw = {
 	mbfl_no_encoding_cp50220raw,
 	"CP50220raw",
 	"ISO-2022-JP",
-	(const char *(*)[])NULL,
+	NULL,
 	NULL,
 	MBFL_ENCTYPE_MBCS | MBFL_ENCTYPE_GL_UNSAFE,
 	&vtbl_cp50220raw_wchar,

ext/mbstring/libmbfl/filters/mbfilter_cp51932.c

@@ -68,7 +68,7 @@ const mbfl_encoding mbfl_encoding_cp51932 = {
 	mbfl_no_encoding_cp51932,
 	"CP51932",
 	"CP51932",
-	(const char *(*)[])&mbfl_encoding_cp51932_aliases,
+	mbfl_encoding_cp51932_aliases,
 	mblen_table_eucjp,
 	MBFL_ENCTYPE_MBCS,
 	&vtbl_cp51932_wchar,

ext/mbstring/libmbfl/filters/mbfilter_cp850.c

@@ -35,7 +35,7 @@ const mbfl_encoding mbfl_encoding_cp850 = {
 	mbfl_no_encoding_cp850,
 	"CP850",
 	"CP850",
-	(const char *(*)[])&mbfl_encoding_cp850_aliases,
+	mbfl_encoding_cp850_aliases,
 	NULL,
 	MBFL_ENCTYPE_SBCS,
 	&vtbl_cp850_wchar,

ext/mbstring/libmbfl/filters/mbfilter_cp866.c

@@ -39,7 +39,7 @@ const mbfl_encoding mbfl_encoding_cp866 = {
 	mbfl_no_encoding_cp866,
 	"CP866",
 	"CP866",
-	(const char *(*)[])&mbfl_encoding_cp866_aliases,
+	mbfl_encoding_cp866_aliases,
 	NULL,
 	MBFL_ENCTYPE_SBCS,
 	&vtbl_cp866_wchar,