Skip to content

Commit 173fe19

Browse files
committed
Fix [-Wimplicit-fallthrough] warnings in PDO SQLite extension
1 parent 1f4d1d0 commit 173fe19

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

ext/pdo_sqlite/sqlite_statement.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ static int pdo_sqlite_stmt_execute(pdo_stmt_t *stmt)
6363

6464
case SQLITE_ERROR:
6565
sqlite3_reset(S->stmt);
66+
fallthrough;
6667
case SQLITE_MISUSE:
6768
case SQLITE_BUSY:
6869
default:
@@ -225,6 +226,7 @@ static int pdo_sqlite_stmt_fetch(pdo_stmt_t *stmt,
225226

226227
case SQLITE_ERROR:
227228
sqlite3_reset(S->stmt);
229+
fallthrough;
228230
default:
229231
pdo_sqlite_error_stmt(stmt);
230232
return 0;
@@ -328,6 +330,8 @@ static int pdo_sqlite_stmt_col_meta(pdo_stmt_t *stmt, zend_long colno, zval *ret
328330

329331
case SQLITE_BLOB:
330332
add_next_index_string(&flags, "blob");
333+
/* TODO Check this is correct */
334+
fallthrough;
331335
case SQLITE_TEXT:
332336
add_assoc_string(return_value, "native_type", "string");
333337
add_assoc_long(return_value, "pdo_type", PDO_PARAM_STR);

0 commit comments

Comments
 (0)