Changed fatals to warnings during startup

Author: frederikpyt

main/main.c

@@ -327,7 +327,7 @@ static PHP_INI_MH(OnChangeMemoryLimit)
 	if (PG(max_memory_limit) != -1) {
 		if (value == -1) {
 			zend_error(
-				stage == ZEND_INI_STAGE_STARTUP ? E_ERROR : E_WARNING,
+				E_WARNING,
 				"Failed to set memory_limit to unlimited. memory_limit (currently: " ZEND_LONG_FMT " bytes) cannot be set to unlimited if max_memory_limit (" ZEND_LONG_FMT " bytes) is not unlimited",
 				PG(memory_limit),
 				PG(max_memory_limit)
@@ -338,7 +338,7 @@ static PHP_INI_MH(OnChangeMemoryLimit)
 
 		if (value > PG(max_memory_limit)) {
 			zend_error(
-				stage == ZEND_INI_STAGE_STARTUP ? E_ERROR : E_WARNING,
+				E_WARNING,
 				"Failed to set memory_limit to %zd bytes. memory_limit (currently: " ZEND_LONG_FMT " bytes) cannot exceed max_memory_limit (" ZEND_LONG_FMT " bytes)",
 				value,
 				PG(memory_limit),

tests/basic/gh17951_ini_parse_4.phpt

@@ -11,6 +11,6 @@ max_memory_limit=128M
 echo ini_get('max_memory_limit') . PHP_EOL;
 echo ini_get('memory_limit') . PHP_EOL;
 --EXPECTF--
-Fatal error: Failed to set memory_limit to unlimited. memory_limit (currently: %d bytes) cannot be set to unlimited if max_memory_limit (%d bytes) is not unlimited in %s
+Warning: Failed to set memory_limit to unlimited. memory_limit (currently: %d bytes) cannot be set to unlimited if max_memory_limit (%d bytes) is not unlimited in %s
 128M
 128M

tests/basic/gh17951_ini_parse_5.phpt

@@ -11,6 +11,6 @@ max_memory_limit=128M
 echo ini_get('max_memory_limit') . PHP_EOL;
 echo ini_get('memory_limit') . PHP_EOL;
 --EXPECTF--
-Fatal error: Failed to set memory_limit to %d bytes. memory_limit (currently: %d bytes) cannot exceed max_memory_limit (%d bytes) in %s
+Warning: Failed to set memory_limit to %d bytes. memory_limit (currently: %d bytes) cannot exceed max_memory_limit (%d bytes) in %s
 128M
 128M