Skip to content

Commit 202a069

Browse files
grooverdannikic
authored andcommitted
mysqli: use native api
Tested with: * mysql-5.6.49-linux-glibc2.12-x86_64 * mysql-5.7.31-linux-glibc2.12-x86_64 * mysql-8.0.21-linux-glibc2.17-x86_64 * mariadb-10.5.6 configure --with-mysqli=/usr/local/$version/bin/mysql_config --with-pdo-mysql=/usr/local/$version MySQL-8.0 removed my_bool Some options where deprecated in mysql-8.0 MY_CHARSET_INFO used with exposed api mysql_get_character_set_info rather than internal structures.
1 parent efc52f1 commit 202a069

File tree

3 files changed

+10
-17
lines changed

3 files changed

+10
-17
lines changed

ext/mysqli/mysqli_api.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ PHP_FUNCTION(mysqli_change_user)
614614
size_t user_len, password_len, dbname_len;
615615
zend_ulong rc;
616616
#if !defined(MYSQLI_USE_MYSQLND) && defined(HAVE_MYSQLI_SET_CHARSET)
617-
const CHARSET_INFO * old_charset;
617+
MY_CHARSET_INFO old_charset;
618618
#endif
619619

620620
if (zend_parse_method_parameters(ZEND_NUM_ARGS(), getThis(), "Osss!", &mysql_link, mysqli_link_class_entry, &user, &user_len, &password, &password_len, &dbname, &dbname_len) == FAILURE) {
@@ -623,7 +623,7 @@ PHP_FUNCTION(mysqli_change_user)
623623
MYSQLI_FETCH_RESOURCE_CONN(mysql, mysql_link, MYSQLI_STATUS_VALID);
624624

625625
#if !defined(MYSQLI_USE_MYSQLND) && defined(HAVE_MYSQLI_SET_CHARSET)
626-
old_charset = mysql->mysql->charset;
626+
mysql_get_character_set_info(mysql->mysql, &old_charset);
627627
#endif
628628

629629
#if defined(MYSQLI_USE_MYSQLND)
@@ -643,7 +643,7 @@ PHP_FUNCTION(mysqli_change_user)
643643
5.0 doesn't support it. Support added in 5.1.23 by fixing the following bug :
644644
Bug #30472 libmysql doesn't reset charset, insert_id after succ. mysql_change_user() call
645645
*/
646-
rc = mysql_set_character_set(mysql->mysql, old_charset->csname);
646+
rc = mysql_set_character_set(mysql->mysql, old_charset.csname);
647647
}
648648
#endif
649649

@@ -1716,10 +1716,12 @@ static int mysqli_options_get_option_zval_type(int option)
17161716
#endif /* MySQL 4.1.0 */
17171717
case MYSQL_OPT_READ_TIMEOUT:
17181718
case MYSQL_OPT_WRITE_TIMEOUT:
1719+
#ifdef MYSQL_OPT_GUESS_CONNECTION /* removed in MySQL-8.0 */
17191720
case MYSQL_OPT_GUESS_CONNECTION:
17201721
case MYSQL_OPT_USE_EMBEDDED_CONNECTION:
17211722
case MYSQL_OPT_USE_REMOTE_CONNECTION:
17221723
case MYSQL_SECURE_AUTH:
1724+
#endif
17231725
#ifdef MYSQL_OPT_RECONNECT
17241726
case MYSQL_OPT_RECONNECT:
17251727
#endif /* MySQL 5.0.13 */

ext/mysqli/mysqli_nonapi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,8 @@ void mysqli_common_connect(INTERNAL_FUNCTION_PARAMETERS, zend_bool is_real_conne
303303
php_mysqli_set_error(mysql_errno(mysql->mysql), (char *) mysql_error(mysql->mysql));
304304

305305
#if !defined(MYSQLI_USE_MYSQLND)
306-
mysql->mysql->reconnect = MyG(reconnect);
306+
char reconnect = MyG(reconnect);
307+
mysql_options(mysql->mysql, MYSQL_OPT_RECONNECT, (char *)&reconnect);
307308
#endif
308309
unsigned int allow_local_infile = MyG(allow_local_infile);
309310
mysql_options(mysql->mysql, MYSQL_OPT_LOCAL_INFILE, (char *)&allow_local_infile);

ext/mysqli/php_mysqli_structs.h

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@
5858
#define HAVE_ULONG
5959
#endif
6060

61-
#include <my_global.h>
62-
6361
#if !defined(HAVE_MBRLEN) && defined(WE_HAD_MBRLEN)
6462
#define HAVE_MBRLEN 1
6563
#endif
@@ -68,20 +66,12 @@
6866
#define HAVE_MBSTATE_T 1
6967
#endif
7068

71-
/*
72-
We need more than mysql.h because we need CHARSET_INFO in one place.
73-
This order has been borrowed from the ODBC driver. Nothing can be removed
74-
from the list of headers :(
75-
*/
76-
77-
#include <my_sys.h>
7869
#include <mysql.h>
70+
#ifndef my_bool
71+
typedef char my_bool;
72+
#endif
7973
#include <errmsg.h>
80-
#include <my_list.h>
81-
#include <m_string.h>
8274
#include <mysqld_error.h>
83-
#include <my_list.h>
84-
#include <m_ctype.h>
8575
#include "mysqli_libmysql.h"
8676
#endif /* MYSQLI_USE_MYSQLND */
8777

0 commit comments

Comments
 (0)