less heavy approach

Author: devnexen

ext/pdo_sqlite/config.m4

@@ -32,6 +32,38 @@ if test "$PHP_PDO_SQLITE" != "no"; then
       https://www.sqlite.org/compile.html.])],
     [$PDO_SQLITE_SHARED_LIBADD])
 
+  AC_CACHE_CHECK([checking sqlite3_stmt_explain support],
+  [php_cv_have_stmt_explain],
+  [AC_RUN_IFELSE([AC_LANG_SOURCE([[
+#include <sqlite3.h>
+#if defined(__APPLE__)
+#include <Availability.h>
+#endif
+
+int main(void) {
+#if SQLITE_VERSION_NUMBER >= 3041000
+#if defined(__APPLE__)
+    if (__builtin_available(macOS 14.2, *)) {
+#endif
+    (void)sqlite3_stmt_explain(NULL, 0);
+    return 0;
+#if defined(__APPLE__)
+    } else {
+        return 1;
+    }
+#endif
+#else
+    return 1;
+#endif
+}
+]])],
+[php_cv_have_stmt_explain=no],
+[php_cv_have_stmt_explain=yes],
+[php_cv_have_stmt_explain=no])])
+AS_VAR_IF([php_cv_have_stmt_explain], [yes],
+  [AC_DEFINE([HAVE_SQLITE3_STMT_EXPLAIN], [1],
+    [Define to 1 if sqlite3_stmt_explain is supported.])])
+
   PHP_SUBST([PDO_SQLITE_SHARED_LIBADD])
   PHP_NEW_EXTENSION([pdo_sqlite],
     [pdo_sqlite.c sqlite_driver.c sqlite_statement.c sqlite_sql_parser.c],

ext/pdo_sqlite/sqlite_statement.c

@@ -26,10 +26,6 @@
 #include "php_pdo_sqlite.h"
 #include "php_pdo_sqlite_int.h"
 
-#if defined(__APPLE__)
-#include <Availability.h>
-#endif
-
 static int pdo_sqlite_stmt_dtor(pdo_stmt_t *stmt)
 {
 	pdo_sqlite_stmt *S = (pdo_sqlite_stmt*)stmt->driver_data;
@@ -391,18 +387,9 @@ static int pdo_sqlite_stmt_get_attribute(pdo_stmt_t *stmt, zend_long attr, zval
 			}
 			break;
         case PDO_SQLITE_ATTR_EXPLAIN_STATEMENT:
-#if SQLITE_VERSION_NUMBER >= 3041000
-#if defined(__APPLE__)
-            if (__builtin_available(macOS 14.2, *)) {
-#endif
-                ZVAL_LONG(val, (zend_long)sqlite3_stmt_isexplain(S->stmt));
-                return 1;
-#if defined(__APPLE__)
-            } else {
-                zend_value_error("explain statement unsupported");
-                return 0;
-            }
-#endif
+#if defined(HAVE_SQLITE3_STMT_EXPLAIN)
+            ZVAL_LONG(val, (zend_long)sqlite3_stmt_isexplain(S->stmt));
+            return 1;
 #else
             zend_value_error("explain statement unsupported");
             return 0;
@@ -420,29 +407,20 @@ static int pdo_sqlite_stmt_set_attribute(pdo_stmt_t *stmt, zend_long attr, zval
 
 	switch (attr) {
         case PDO_SQLITE_ATTR_EXPLAIN_STATEMENT:
-#if SQLITE_VERSION_NUMBER >= 3041000
-#if defined(__APPLE__)
-            if (__builtin_available(macOS 14.2, *)) {
-#endif
-                if (Z_TYPE_P(zval) != IS_LONG) {
-                    zend_type_error("explain mode must be of type int");
-                    return 0;
-                }
-                if (Z_TYPE_P(zval) < 0 || Z_TYPE_P(zval) > 2) {
-                    zend_value_error("explain mode must be one of the EXPLAIN_MODE_* constants");
-                    return 0;
-                }
-                if (sqlite3_stmt_explain(S->stmt, (int)Z_LVAL_P(zval)) != SQLITE_OK) {
-                    return 0;
-                }
-
-                return 1;
-#if defined(__APPLE__)
-            } else {
-                zend_value_error("explain statement unsupported");
+#if defined(HAVE_SQLITE3_STMT_EXPLAIN)
+            if (Z_TYPE_P(zval) != IS_LONG) {
+                zend_type_error("explain mode must be of type int");
                 return 0;
             }
-#endif
+            if (Z_TYPE_P(zval) < 0 || Z_TYPE_P(zval) > 2) {
+                zend_value_error("explain mode must be one of the EXPLAIN_MODE_* constants");
+                return 0;
+            }
+            if (sqlite3_stmt_explain(S->stmt, (int)Z_LVAL_P(zval)) != SQLITE_OK) {
+                return 0;
+            }
+
+            return 1;
 #else
             zend_value_error("explain statement unsupported");
             return 0;