ext/phar: reclassify various exception

Main purpose is to use ValueError/TypeError in cases that are about value/type validation.
This fixes the wording to match the more usual wording.

Secondly use Error when an object is not initialized or one attemps to call the constructor twice, similar to other extensions

Author: Girgias

ext/phar/phar_object.c

@@ -123,7 +123,7 @@ public function delete(string $localName): true {}
     public function delMetadata(): true {}
 
     /** @tentative-return-type */
-    public function extractTo(string $directory, array|string|null $files = null, bool $overwrite = false): bool {}
+    public function extractTo(string $directory, array|string|null $files = null, bool $overwrite = false): true {}
 
     /** @tentative-return-type */
     public function getAlias(): ?string {}
@@ -345,7 +345,7 @@ public function delMetadata(): true {}
      * @tentative-return-type
      * @implementation-alias Phar::extractTo
      */
-    public function extractTo(string $directory, array|string|null $files = null, bool $overwrite = false): bool {}
+    public function extractTo(string $directory, array|string|null $files = null, bool $overwrite = false): true {}
 
     /**
      * @tentative-return-type

ext/phar/phar_object.stub.php

@@ -27,9 +27,9 @@ require $pname . '/a.php';
 $p = new Phar($fname);
 var_dump(isset($p['.phar/test']));
 try {
-$p['.phar/test'];
-} catch (Exception $e) {
-echo $e->getMessage(),"\n";
+	$p['.phar/test'];
+} catch (Throwable $e) {
+    echo $e::class, ': ', $e->getMessage() . "\n";
 }
 ?>
 --CLEAN--
@@ -43,4 +43,4 @@ This is b/c
 This is b/d
 This is e
 bool(false)
-Cannot directly get any files or directories in magic ".phar" directory
+ValueError: Phar::offsetGet(): Argument #1 ($localName) must not start with ".phar"

ext/phar/phar_object_arginfo.h

@@ -26,14 +26,16 @@ var_dump(is_dir($outDir.DIRECTORY_SEPARATOR.'dirAB'));
 try {
   $pharB->extractTo($outDir, 'dirX/', true);
   echo 'failed to throw expected exception';
-} catch (PharException $ex) {
+} catch (Throwable $e) {
+    echo $e::class, ': ', $e->getMessage() . "\n";
 }
 
 // should also not be able to pull out /, because paths are not "rooted" that way
 try {
   $pharB->extractTo($outDir, '/', true);
   echo 'failed to throw expected exception';
-} catch (PharException $ex) {
+} catch (Throwable $e) {
+    echo $e::class, ': ', $e->getMessage() . "\n";
 }
 
 // should be able to do by array, too
@@ -45,7 +47,8 @@ try {
   $pharB = new Phar($phar);
   $pharB->extractTo($outDir, [ 'dirA/', 'dirX/' ], true);
   echo 'failed to throw expected exception';
-} catch (PharException $ex) {
+} catch (Throwable $e) {
+    echo $e::class, ': ', $e->getMessage() . "\n";
 }
 
 echo 'done';
@@ -63,8 +66,11 @@ foreach ($iter as $value) {
     $value->isFile() ? unlink($value) : rmdir($value);
 }
 ?>
---EXPECT--
+--EXPECTF--
 bool(true)
 bool(true)
 bool(false)
+PharException: phar error: attempted to extract non-existent file or directory "dirX/" from phar "%sbug54289/test.phar"
+PharException: phar error: attempted to extract non-existent file or directory "/" from phar "%sbug54289/test.phar"
+PharException: phar error: attempted to extract non-existent file or directory "dirX/" from phar "%sbug54289/test.phar"
 done

ext/phar/tests/030.phpt

@@ -59,5 +59,5 @@ $workdir = __DIR__.'/getPathname_exception';
 [ Found: %shello.txt ]
 [getPathname]
 string(%d) "%shello.txt"
-getPathname() must return a string
+MyGlobIterator::getPathname(): Return value must be of type string, null returned
 Previous: exception in getPathname()

ext/phar/tests/bug54289.phpt

@@ -55,4 +55,4 @@ $workdir = __DIR__.'/getPathname_wrong_type';
 --EXPECTF--
 [ Found: %scontent%chello.txt ]
 [getPathname]
-getPathname() must return a string
+MyGlobIterator::getPathname(): Return value must be of type string, int returned

ext/phar/tests/buildFromIterator_user_overrides/getPathname_exception.phpt

@@ -14,7 +14,7 @@ files/frontcontroller6.phar
 --EXPECTHEADERS--
 Content-type: text/html; charset=UTF-8
 --EXPECTF--
-Fatal error: Uncaught PharException: Unknown mime type specifier used, only Phar::PHP, Phar::PHPS and a mime type string are allowed in %sfrontcontroller12.php:2
+Fatal error: Uncaught ValueError: Phar::webPhar(): Argument #4 ($mimeTypes) mime type specifier must be one of Phar::PHP or Phar::PHPS in %sfrontcontroller12.php:2
 Stack trace:
 #0 %sfrontcontroller12.php(2): Phar::webPhar('whatever', 'index.php', NULL, Array)
 #1 {main}

ext/phar/tests/buildFromIterator_user_overrides/getPathname_wrong_type.phpt

@@ -14,7 +14,7 @@ files/frontcontroller7.phar
 --EXPECTHEADERS--
 Content-type: text/html; charset=UTF-8
 --EXPECTF--
-Fatal error: Uncaught PharException: Unknown mime type specifier used (not a string or int), only Phar::PHP, Phar::PHPS and a mime type string are allowed in %sfrontcontroller13.php:2
+Fatal error: Uncaught TypeError: Phar::webPhar(): Argument #4 ($mimeTypes) mime type specifier must be of type string|int, null given in %sfrontcontroller13.php:2
 Stack trace:
 #0 %sfrontcontroller13.php(2): Phar::webPhar('whatever', 'index.php', NULL, Array)
 #1 {main}

ext/phar/tests/cache_list/frontcontroller12.phpt

@@ -11,7 +11,7 @@ PATH_INFO=/fronk.gronk
 --FILE_EXTERNAL--
 files/frontcontroller9.phar
 --EXPECTF--
-Fatal error: Uncaught PharException: No values passed to Phar::mungServer(), expecting an array of any of these strings: PHP_SELF, REQUEST_URI, SCRIPT_FILENAME, SCRIPT_NAME in %sfrontcontroller18.php:2
+Fatal error: Uncaught ValueError: Phar::mungServer(): Argument #1 ($variables) must not be empty in %sfrontcontroller18.php:2
 Stack trace:
 #0 %sfrontcontroller18.php(2): Phar::mungServer(Array)
 #1 {main}