Skip to content

Commit 2b33462

Browse files
committed
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3: Revert "Fix #80852: Stack-overflow when json_encode()'ing SimpleXMLElement"
2 parents 7663701 + 1b88c85 commit 2b33462

File tree

2 files changed

+2
-23
lines changed

2 files changed

+2
-23
lines changed

ext/simplexml/simplexml.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,7 +1211,7 @@ static HashTable *sxe_get_prop_hash(zval *object, int is_debug) /* {{{ */
12111211
}
12121212
}
12131213

1214-
if (node->type == XML_ELEMENT_NODE && (! match_ns(sxe, node, sxe->iter.nsprefix, sxe->iter.isprefix)) || node->type == XML_ENTITY_DECL) {
1214+
if (node->type == XML_ELEMENT_NODE && (! match_ns(sxe, node, sxe->iter.nsprefix, sxe->iter.isprefix))) {
12151215
goto next_iter;
12161216
}
12171217

@@ -1908,7 +1908,7 @@ static int sxe_object_cast_ex(zval *readobj, zval *writeobj, int type)
19081908

19091909
if (sxe->node && sxe->node->node) {
19101910
if (sxe->node->node->children) {
1911-
contents = xmlNodeListGetRawString((xmlDocPtr) sxe->document->ptr, sxe->node->node->children, 1);
1911+
contents = xmlNodeListGetString((xmlDocPtr) sxe->document->ptr, sxe->node->node->children, 1);
19121912
}
19131913
}
19141914
}

ext/simplexml/tests/bug80852.phpt

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)