fix to follow each call proper behavior.

a negative pid is acceptable for kill as it represents a process group
id while setpgid the pid must be at least 0.

Author: devnexen

ext/posix/posix.c

@@ -46,8 +46,10 @@
 #endif
 
 #if (defined(__sun) && !defined(_LP64)) || defined(_AIX)
+#define POSIX_PID_MIN LONG_MIN
 #define POSIX_PID_MAX LONG_MAX
 #else
+#define POSIX_PID_MIN INT_MIN
 #define POSIX_PID_MAX INT_MAX
 #endif
 
@@ -124,10 +126,10 @@ ZEND_GET_MODULE(posix)
 	}	\
 	RETURN_TRUE;
 
-#define PHP_POSIX_CHECK_PID(pid)									\
-	if (pid < -1 || pid > POSIX_PID_MAX) {								\
-		zend_argument_value_error(1, "must be between -1 and " ZEND_LONG_FMT, POSIX_PID_MAX);	\
-		RETURN_THROWS();									\
+#define PHP_POSIX_CHECK_PID(pid, lower, upper)										\
+	if (pid < lower || pid > upper) {										\
+		zend_argument_value_error(1, "must be between " ZEND_LONG_FMT " and " ZEND_LONG_FMT, lower, upper);	\
+		RETURN_THROWS();											\
 	}
 
 /* {{{ Send a signal to a process (POSIX.1, 3.3.2) */
@@ -141,7 +143,7 @@ PHP_FUNCTION(posix_kill)
 		Z_PARAM_LONG(sig)
 	ZEND_PARSE_PARAMETERS_END();
 
-	PHP_POSIX_CHECK_PID(pid)
+	PHP_POSIX_CHECK_PID(pid, POSIX_PID_MIN, POSIX_PID_MAX)
 
 	if (kill(pid, sig) < 0) {
 		POSIX_G(last_error) = errno;
@@ -305,7 +307,7 @@ PHP_FUNCTION(posix_setpgid)
 		Z_PARAM_LONG(pgid)
 	ZEND_PARSE_PARAMETERS_END();
 
-	PHP_POSIX_CHECK_PID(pid)
+	PHP_POSIX_CHECK_PID(pid, 0, POSIX_PID_MAX)
 
 	if (setpgid(pid, pgid) < 0) {
 		POSIX_G(last_error) = errno;

ext/posix/tests/posix_kill_error.phpt

@@ -13,7 +13,7 @@ $sig = 999;
 var_dump( posix_kill($pid, 999) );
 
 echo "\n-- Testing posix_kill() function with negative pid --\n";
-$pid = -1;
+$pid = -999;
 $sig = 9;
 var_dump( posix_kill($pid, 999) );
 

ext/posix/tests/posix_kill_pidoverflow.phpt

@@ -20,5 +20,5 @@ try {
 }
 ?>
 --EXPECTF--
-posix_kill(): Argument #1 ($process_id) must be between -1 and %d
-posix_kill(): Argument #1 ($process_id) must be between -1 and %d
+posix_kill(): Argument #1 ($process_id) must be between %d and %d
+posix_kill(): Argument #1 ($process_id) must be between %d and %d

ext/posix/tests/posix_setpgid_error.phpt

@@ -18,5 +18,5 @@ try {
 }
 ?>
 --EXPECTF--
-posix_setpgid(): Argument #1 ($process_id) must be between -1 and %d
-posix_setpgid(): Argument #1 ($process_id) must be between -1 and %d
+posix_setpgid(): Argument #1 ($process_id) must be between 0 and %d
+posix_setpgid(): Argument #1 ($process_id) must be between 0 and %d