Don't explicitly set return value on ZPP failure in ext/xml

cmb69 · cmb69 · commit 37713c80e49b · 2019-09-03T13:12:05.000+02:00
Failing ZPP throws as of PHP 8.0.0, so explicitly setting a return
value is useless, and also slightly confusing.
diff --git a/ext/xml/xml.c b/ext/xml/xml.c
@@ -1065,7 +1065,7 @@ static void php_xml_parser_create_impl(INTERNAL_FUNCTION_PARAMETERS, int ns_supp
 	XML_Char *encoding;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS(), (ns_support ? "|ss": "|s"), &encoding_param, &encoding_param_len, &ns_param, &ns_param_len) == FAILURE) {
-		RETURN_FALSE;
+		return;
 	}
 
 	if (encoding_param != NULL) {

Original file line number	Diff line number	Diff line change
`@@ -1065,7 +1065,7 @@ static void php_xml_parser_create_impl(INTERNAL_FUNCTION_PARAMETERS, int ns_supp`
`1065`	`1065`	`XML_Char *encoding;`
`1066`	`1066`
`1067`	`1067`	`if (zend_parse_parameters(ZEND_NUM_ARGS(), (ns_support ? "\|ss": "\|s"), &encoding_param, &encoding_param_len, &ns_param, &ns_param_len) == FAILURE) {`
`1068`		`- RETURN_FALSE;`
	`1068`	`+ return;`
`1069`	`1069`	`}`
`1070`	`1070`
`1071`	`1071`	`if (encoding_param != NULL) {`