Fix [-Wimplicit-fallthrough] warnings in MBString extension

Girgias · Girgias · commit 380eb59a4e44 · 2021-02-04T12:07:35.000Z
diff --git a/ext/mbstring/libmbfl/filters/mbfilter_sjis_mac.c b/ext/mbstring/libmbfl/filters/mbfilter_sjis_mac.c
@@ -373,6 +373,7 @@ mbfl_filt_conv_wchar_sjis_mac(int c, mbfl_convert_filter *filter)
 			break;
 		}
 		s1 = s2 = 0;
+		fallthrough;
 
 	case 0:
 
diff --git a/ext/mbstring/mbstring.c b/ext/mbstring/mbstring.c
@@ -3351,7 +3351,7 @@ static int _php_mbstr_parse_mail_headers(HashTable *ht, const char *str, size_t
 							state = 3;
 							break;
 						}
-						/* break is missing intentionally */
+						fallthrough;
 
 					case 3:
 						if (crlf_state == -1) {

Original file line number	Diff line number	Diff line change
`@@ -373,6 +373,7 @@ mbfl_filt_conv_wchar_sjis_mac(int c, mbfl_convert_filter *filter)`
`373`	`373`	`break;`
`374`	`374`	`}`
`375`	`375`	`s1 = s2 = 0;`
	`376`	`+ fallthrough;`
`376`	`377`
`377`	`378`	`case 0:`
`378`	`379`
Original file line number	Diff line number	Diff line change
`@@ -3351,7 +3351,7 @@ static int _php_mbstr_parse_mail_headers(HashTable ht, const char str, size_t`
`3351`	`3351`	`state = 3;`
`3352`	`3352`	`break;`
`3353`	`3353`	`}`
`3354`		`- /* break is missing intentionally */`
	`3354`	`+ fallthrough;`
`3355`	`3355`
`3356`	`3356`	`case 3:`
`3357`	`3357`	`if (crlf_state == -1) {`